Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix for annots without shape #466

Merged
merged 3 commits into from
Dec 16, 2020
Merged

hotfix for annots without shape #466

merged 3 commits into from
Dec 16, 2020

Conversation

birm
Copy link
Member

@birm birm commented Dec 16, 2020 •
edited
Loading

Fixes #465

I'm not yet sure of any knock-on effects, so I'm testing. Of course, I want @nanli-emory / @JasoxLee to yell at me if this is a bad change 😺

nanli-emory
nanli-emory requested changes Dec 16, 2020
View reviewed changes
Copy link
Member

@nanli-emory nanli-emory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set the default value of item.shape to ["Polygon"]

if (!item.shape) item.shape = ["Polygon"]

@birm birm merged commit 9451af9 into develop Dec 16, 2020
@birm birm deleted the fix465 branch December 16, 2020 20:25
@birm birm mentioned this pull request Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanli-emory nanli-emory nanli-emory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@birm @nanli-emory