-
Notifications
You must be signed in to change notification settings - Fork 308
Contribution guidelines and pull request template addition #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Vedant1202 , this looks nice ! We really needed a contributing.md |
|
@cjchirag7 Thanks for the review. There is no change in the system as such it's just an addition as a documentation context. If it's reviewed and passed by the maintainers, I think merging into |
|
@cjchirag7 I have however, missed adding the line where you've to request to pull a merge into the |
cjchirag7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vedant1202 , please consider these changes, if it seems correct.
Co-Authored-By: Chirag Jain <cjchirag7@gmail.com>
… into contrib-PR
|
@cjchirag7 I've made the changes, thanks for the suggestions. |
|
Hi, thanks for putting this together. |
|
I think it's ok to discuss here or in the issue. I just don't want to forget to actually do a release this week, before there are too many changes. (Also, as you pointed out, the contributing guidelines don't go into effect until we merge) |
|
After talking with other contributors, It looks like we want to keep develop, so that checking out master is the same as checking out the latest release. |
birm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'll leave this up for just a little longer so that anyone else who wants to comment can.
Added a draft for contribution guidelines and pull request template.