For 3.7.1 #309
Merged
For 3.7.1 #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow empty note when saving annotation
* Made all identifers in components/ in camelCase to remove camelCase rule of ESLint * Made identifiers in apps folder to be in camelCase * changed anno_delte to annoDelte * Fixed camelCase in init.js and table.html * Update spyglass.js merge request #278 variable name changing ====> `_target_viewer` => `_targetViewer`. * Update uicallbacks.js 1. `toolbar._main_tools` => `toolbar._mainTools`, there are 8 places in `apps/veiwer/uicallbacks.js` that need to change when you change the variable`_main_tools` to `_mainTools` in `components/toolbar/toolbar.js`. [line 17, 23, 1053, 1079, 1092, 1096, 1215, 1221] 2. `toolbar._sub_tools` => `toolbar._subTools`, there are 3 places in `apps/segment/segment.js`(2 places - line 850, 851 removed), `apps/labeling/labeling.js` (1 place - line 84) that need to change when you change the variable`_sub_tools` to `_subTools` in `components/toolbar/toolbar.js`. * Update labeling.js `toolbar._sub_tools` => `toolbar._subTools` * Update segment.js `toolbar._sub_tools` => `toolbar._subTools` Co-authored-by: nanli-emory <40213692+nanli-emory@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: POST instead of UPDATE tables
Features:
Style: camel case checks (#278)