Skip to content

Clean loader code and increase upload modal width #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
birm merged 3 commits into from
Apr 7, 2020
Merged

Clean loader code and increase upload modal width #331

birm merged 3 commits into from
Apr 7, 2020

Conversation

@cjchirag7
Copy link
Contributor

@cjchirag7 cjchirag7 commented Apr 6, 2020

Closes #326
This includes the following changes :

  • Refactored loader code to support only a single file upload, at a time
  • Cursor has been made 👆 when users hovers over the 'choose file' (browse) button in the modal
  • The resetUploadForm() has been modified, in accordance with Upload form redesign and upload button visibility #325
  • The upload modal width is increased
    After increased width, the modal look like this, on an average PC -
    wide-modal

@cjchirag7 cjchirag7 changed the title Clean loader code Clean loader code and increase upload modal width Apr 6, 2020
@birm birm self-requested a review April 7, 2020 02:16
birm
birm requested changes Apr 7, 2020
View reviewed changes
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, just a little additional removal 🙂

@cjchirag7
Copy link
Contributor Author

cjchirag7 commented Apr 7, 2020

@birm , I have made the required changes.

birm
birm approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the fix and incorporating comments!

@birm birm merged commit 8b9bfc8 into camicroscope:develop Apr 7, 2020
@birm birm mentioned this pull request Apr 7, 2020
Closed
@cjchirag7 cjchirag7 deleted the clean-loader-code branch April 7, 2020 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@birm birm birm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cjchirag7 @birm