Skip to content

Conversation

@akhil-rana
Copy link
Contributor

  1. The Slide Upload form is slightly redesigned to match the application.
  2. Now, the upload button will only be visible to the user who has the permission to upload a slide.(Using what can i do route)

Old:
Screenshot from 2020-04-06 07-07-38

New:
Screenshot from 2020-04-06 07-07-12

@birm birm self-requested a review April 6, 2020 02:15
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, it looks like this removed the ability to add multiple slides at once.
I have no objection to that, but in that case, we can probably simplify the code to only have to deal with one slide at a time.

@akhil-rana
Copy link
Contributor Author

I also noticed that the multiple keyword was missing in the previous design itself.
I realised that,
It was removed in #313

@birm
Copy link
Member

birm commented Apr 6, 2020

Ok, then we can merge this and let simplifying the code be a separate issue.

@birm birm merged commit b1e4d94 into camicroscope:develop Apr 6, 2020
@akhil-rana akhil-rana deleted the uploadFormRedesign_uploadButtonVisible branch June 18, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants