Prepare r2.2 #193

fernandopradocabrillo · 2025-02-27T13:48:55Z

What type of PR is this?

Add one of the following kinds:

subproject management

What this PR does / why we need it:

Preparations for Public release r2.2 for Spring25 meta

Which issue(s) this PR fixes:

Fixes #188

Special notes for reviewers:

This PR needs to be merged after:
- Add 400 OUT_OF_RANGE error when the maxAge is above 2400 #189
- Align sim swap subscriptions with latest Commonalities #192
References to these two PRs have already been included in the CHANGELOG.md file

… into prepare-r2.2

bigludo7

Look good for me.
Thanks @fernandopradocabrillo
Adding the @camaraproject/release-management_maintainers as reviewer

rartych · 2025-03-07T13:01:20Z

CHANGELOG.md

+### Changed
+* Update sim-swap-check.feature by @bigludo7 in https://github.com/camaraproject/SimSwap/pull/168
+* Update test wording to avoid confusion with "activation" terminology by @fernandopradocabrillo in https://github.com/camaraproject/SimSwap/pull/170
+* Sim swap alignement with  commonalities 0.5 by @bigludo7 in https://github.com/camaraproject/SimSwap/pull/180


Typos:

Suggested change

* Sim swap alignement with commonalities 0.5 by @bigludo7 in https://github.com/camaraproject/SimSwap/pull/180

* Sim swap alignment with Commonalities 0.5 by @bigludo7 in https://github.com/camaraproject/SimSwap/pull/180

rartych · 2025-03-07T13:02:09Z

CHANGELOG.md

+* Include pattern for x-correlator header by @fernandopradocabrillo in https://github.com/camaraproject/SimSwap/pull/183
+
+### Changed
+* Sim swap subscriptions alignement with commonalities 0.5 by @bigludo7 in https://github.com/camaraproject/SimSwap/pull/179


Typos:

Suggested change

* Sim swap subscriptions alignement with commonalities 0.5 by @bigludo7 in https://github.com/camaraproject/SimSwap/pull/179

* Sim swap subscriptions alignment with Commonalities 0.5 by @bigludo7 in https://github.com/camaraproject/SimSwap/pull/179

This suggestion is not committed yet, but makes sense.

Yep, I missed this one, thanks!

rartych · 2025-03-10T09:41:14Z

In sim-swap-API-Readiness-Checklist.md point 9 Test result statement should include link to "test result statement" i.e. issue #186
The issue itself needs to be updated with the statement see: camaraproject/QualityOnDemand#418

rartych · 2025-03-10T09:53:16Z

In sim-swap-subscriptions.yaml line 444 needs to be update like:
description: "The type of the credential. With the current API version the type MUST be set to ACCESSTOKEN"
or like in https://github.com/camaraproject/Commonalities/pull/404/files

Is line 39:
- the Access Token sinkCredential (optionally set by the requester) expiration time has been reached not confusing?
Access Token is mandatory, maybe it can be modified like that:
- the Access Token sinkCredential expiration time (set by the requester) has been reached

rartych · 2025-03-10T17:56:59Z

For incubating projects in README.md following should changes are needed:

add line 8:
<a href="/camaraproject/Governance/blob/main/ProjectStructureAndRoles.md" title="Incubating API Repository"><img src="https://img.shields.io/badge/Incubating%20API%20Repository-green?style=plastic"></a>
in Scope section last line Location: virtually replace with :
Incubating stage since: February 2025

cf. camaraproject/Governance#174

tanjadegroot

Some comments on the readme

tanjadegroot · 2025-03-11T01:39:53Z

README.md

in README: a few updates please:

line 11: replace "API family" by "APIs" (family is deprecated)
line 16 : replace "customer" by "API provider"
line 20: remove the line (info is in meeting section below)

please check that the scope reflects the latest features of the APIs.

Should "SIM pairing change" be rewritten to something less technical ? on devices and SIMs ?

thanks @tanjadegroot, I think that the scope definition is pretty straightforward but perhaps I am too used to working with these apis and my opinion is flawed.
@bigludo7 wdyt about the scope definition?
We are open to suggestions 😄

README.md

hdamker · 2025-03-11T19:25:05Z

README.md

 # SimSwap

-Repository to describe, develop, document and test the SimSwap API family
+Repository to describe, develop, document and test the SimSwap APIs


Suggested change

Repository to describe, develop, document and test the SimSwap APIs

Incubating API Repository to evolve and maintain the definitions and documentation of SimSwap Service APIs within the Sub Project [Number Verification](https://lf-camaraproject.atlassian.net/wiki/x/BYEpBQ)

* API Repository wiki page: https://lf-camaraproject.atlassian.net/wiki/x/AgDe

* Sub Project home page: https://lf-camaraproject.atlassian.net/wiki/x/0jXe

tanjadegroot

All OK and approval for the README updates. One small tweek.
I just give a comment as the rest of the review and RM approval is with Rafal :-)

tanjadegroot · 2025-03-12T00:28:46Z

README.md


 * Service APIs for “SimSwap” (see APIBacklog.md)  
-* It provides the customer with the ability to:  
+* The APIs provide the API Consumer with the ability to:  


Suggested change

* The APIs provide the API Consumer with the ability to:

* The APIs provide the API consumer with the ability to:

tanjadegroot · 2025-03-12T00:30:09Z

code/API_definitions/sim-swap-subscriptions.yaml

    Note: Additionally to these list, ``org.camaraproject.sim-swap-subscriptions.v0.subscription-ends`` notification `types` is sent when the subscription ends.
    This notification does not require dedicated subscription.
    It is used when:
      - the subscription expire time (optionally set by the requester) has been reached


Suggested change

- the subscription expire time (optionally set by the requester) has been reached

- the subscription expiration time (optionally set by the requester) has been reached

hdamker

Two comments / suggestions from my side

hdamker · 2025-03-12T14:12:48Z

README.md

+Incubating API Repository to evolve and maintain the definitions and documentation of SimSwap Service APIs within the Sub Project [Number Verification](https://lf-camaraproject.atlassian.net/wiki/x/BYEpBQ)
+
+* API Repository wiki page: https://lf-camaraproject.atlassian.net/wiki/x/AgDe
+* Sub Project home page: https://lf-camaraproject.atlassian.net/wiki/x/0jXe


The link is currently only pointing to the wiki home page.

Two options:

Suggested change

* Sub Project home page: https://lf-camaraproject.atlassian.net/wiki/x/0jXe

* Sub Project home page: https://lf-camaraproject.atlassian.net/wiki/x/BYEpBQ

or (as the link is already in line 13, I consider to change the template as well):

Suggested change

* Sub Project home page: https://lf-camaraproject.atlassian.net/wiki/x/0jXe

I would go with the second one, it's one link less to maintain and we avoid duplicates

hdamker · 2025-03-12T14:14:29Z

CHANGELOG.md

+* Include pattern for x-correlator header by @fernandopradocabrillo in https://github.com/camaraproject/SimSwap/pull/183
+
+### Changed
+* Sim swap subscriptions alignement with commonalities 0.5 by @bigludo7 in https://github.com/camaraproject/SimSwap/pull/179


This suggestion is not committed yet, but makes sense.

documentation/API_documentation/sim-swap-API-Readiness-Checklist.md

…st.md Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>

… into prepare-r2.2

bigludo7

LGTM
Thanks Fernando !

rartych

LGTM from Release Management

fernandopradocabrillo added 5 commits February 27, 2025 14:19

update yaml version

939d342

update .feature files

e27165d

update api readiness checklist

1dcd912

update changelog

e9a387d

update readme

6179756

fernandopradocabrillo added the Spring25 Spring25 release preparation label Feb 27, 2025

fernandopradocabrillo requested a review from bigludo7 as a code owner February 27, 2025 13:48

Merge branch 'main' of https://github.com/fernandopradocabrillo/SimSwap…

18e5652

… into prepare-r2.2

bigludo7 previously approved these changes Feb 27, 2025

View reviewed changes

bigludo7 requested a review from a team February 27, 2025 16:58

hdamker mentioned this pull request Feb 28, 2025

SimSwap r2.2 (Spring25 M4) release review camaraproject/ReleaseManagement#185

Closed

19 tasks

rartych reviewed Mar 7, 2025

View reviewed changes

tanjadegroot requested changes Mar 11, 2025

View reviewed changes

tanjadegroot reviewed Mar 11, 2025

View reviewed changes

README.md Outdated Show resolved Hide resolved

changes from RM review

1e78f68

fernandopradocabrillo dismissed bigludo7’s stale review via 1e78f68 March 11, 2025 17:26

fernandopradocabrillo requested review from rartych and tanjadegroot March 11, 2025 17:26

hdamker reviewed Mar 11, 2025

View reviewed changes

tanjadegroot reviewed Mar 12, 2025

View reviewed changes

minor fixes

1c49748

hdamker reviewed Mar 12, 2025

View reviewed changes

changes from review

826a9b5

rartych reviewed Mar 13, 2025

View reviewed changes

documentation/API_documentation/sim-swap-API-Readiness-Checklist.md Outdated Show resolved Hide resolved

Update documentation/API_documentation/sim-swap-API-Readiness-Checkli…

9bb2809

…st.md Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>

fernandopradocabrillo requested a review from rartych March 13, 2025 09:29

fernandopradocabrillo requested review from hdamker and tanjadegroot March 13, 2025 09:29

Merge branch 'main' of https://github.com/fernandopradocabrillo/SimSwap…

ab18b81

… into prepare-r2.2

bigludo7 approved these changes Mar 13, 2025

View reviewed changes

rartych approved these changes Mar 13, 2025

View reviewed changes

fernandopradocabrillo merged commit 315d451 into camaraproject:main Mar 13, 2025
2 checks passed

	* Sim swap alignement with commonalities 0.5 by @bigludo7 in https://github.com/camaraproject/SimSwap/pull/180
	* Sim swap alignment with Commonalities 0.5 by @bigludo7 in https://github.com/camaraproject/SimSwap/pull/180

	* Sim swap subscriptions alignement with commonalities 0.5 by @bigludo7 in https://github.com/camaraproject/SimSwap/pull/179
	* Sim swap subscriptions alignment with Commonalities 0.5 by @bigludo7 in https://github.com/camaraproject/SimSwap/pull/179

	* The APIs provide the API Consumer with the ability to:
	* The APIs provide the API consumer with the ability to:

	- the subscription expire time (optionally set by the requester) has been reached
	- the subscription expiration time (optionally set by the requester) has been reached

	* Sub Project home page: https://lf-camaraproject.atlassian.net/wiki/x/0jXe
	* Sub Project home page: https://lf-camaraproject.atlassian.net/wiki/x/BYEpBQ

Prepare r2.2 #193

Prepare r2.2 #193

Uh oh!

Conversation

fernandopradocabrillo commented Feb 27, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewers:

Uh oh!

bigludo7 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rartych commented Mar 10, 2025

Uh oh!

rartych commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rartych commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tanjadegroot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hdamker Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tanjadegroot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hdamker left a comment

Choose a reason for hiding this comment

Uh oh!

hdamker Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bigludo7 left a comment

Choose a reason for hiding this comment

Uh oh!

rartych left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rartych commented Mar 10, 2025 •

edited

Loading

rartych commented Mar 10, 2025 •

edited

Loading

hdamker Mar 11, 2025 •

edited

Loading

hdamker Mar 12, 2025 •

edited

Loading