Add 400 OUT_OF_RANGE error when the maxAge is above 2400

[bigludo7]

What type of PR is this?

Add one of the following kinds:

• enhancement/feature

What this PR does / why we need it:

• Add 400 OUT_OF_RANGE error when the maxAge is above 2400

Which issue(s) this PR fixes:

Fixes #187

Special notes for reviewers:

Changelog input

 release-note
- Add 403 with code OUT_OF_RANGE when the maxAge is above 2400

Additional documentation

This section can be blank.

docs

[github-actions]

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ ACTION	actionlint	2		0	0.02s
✅ OPENAPI	spectral	2		0	3.34s
✅ REPOSITORY	git_diff	yes		no	0.01s
✅ REPOSITORY	secretlint	yes		no	0.77s
✅ YAML	yamllint	2		0	0.59s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by

[hdamker]

@bigludo7 I edited the title and the description of the PR, as the content is a 400, not a 403 error response.

[gregory1g]

This is a very generic definition. A client which will receive such error code will have to guess what exactly value is out of the range and what this range is. The error must explicitly say this.
If we introduce this error for maxAge > 24000 only - we can describe this in he API description. So, a client knows what the error is really about.

[bigludo7]

As we have very few attribute in this check request (only the maxAge in 3-legs, maxAge & phoneNumber in the 2-legs scenario) I have no problem to custom our message to SIM_SWAP.MAX_AGE_OUT_OF_RANGE.
@gregory1g @fernandopradocabrillo @QaunainM work for you?

[fernandopradocabrillo]

I prefer to stick with the generic one from commonalities artifact. The message is a free text field that can be customized by the implementation. If you feel that it is something critical we can use a message like: "Client specified a value of maxAge outside the defined range"

[bigludo7]

@fernandopradocabrillo Yes make sense - I've forget our message capability - This seems to me a better approach.

[fernandopradocabrillo]

To have in mind for this PR: #184 (reply in thread)

[fernandopradocabrillo]

LGTM