-
Notifications
You must be signed in to change notification settings - Fork 8
Prepare r1.2 #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare r1.2 #62
Conversation
# Conflicts: # documentation/API_documentation/device-data-volume-API-Readiness-Checklist.md # documentation/API_documentation/device-data-volume-subscriptions-API-Readiness-Checklist.md
|
Put to Draft until #63 is merged. |
|
@sachinvodafone please review again this one here :) |
code/Test_definitions/device-data-volume-checkDataVolume.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/device-data-volume-retrieveDataVolume.feature
Outdated
Show resolved
Hide resolved
documentation/API_documentation/device-data-volume-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/device-data-volume-subscriptions-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
Kevsy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor changes suggested, otherwise LGTM 👍
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
…eren Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Kevsy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review checklist complete and comments addressed - LGTM
|
Approved for release management, next steps required by the @camaraproject/device-data-volume_codeowners :
|
code/Test_definitions/device-data-volume-checkDataVolume.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/device-data-volume-retrieveDataVolume.feature
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
|
Approved for release management, next steps required by the @camaraproject/device-data-volume_codeowners :
|
Kevsy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on behalf of release management
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Preparations for Release candidate r1.2 - Fall25
Which issue(s) this PR fixes:
Fixes #57