Skip to content

Linting rules update #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rartych merged 4 commits into from
Jul 24, 2025
Merged

Linting rules update #502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4420a7d
Update .gherkin-lintrc
rartych Jul 17, 2025
c85cf6e
Update .spectral.yml
rartych Jul 17, 2025
fb8d277
Update .spectral.yml
rartych Jul 17, 2025
efb46a2
Update .spectral.yml
rartych Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion artifacts/linting_rules/.gherkin-lintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
}],
"file-name": ["off", {"style": "kebab-case"}],
"max-scenarios-per-file": ["on", {"maxScenarios": 50, "countOutlineExamples": true}],
"no-restricted-patterns": ["on", {
"no-restricted-patterns": ["off", {
Copy link
Contributor

@jlurien jlurien Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we could remove the problematic patterns but I don't find the rest of patterns specially relevant for us now, so OK to disable it. If we find some interesting pattern to consider in the future we can adjust again the rule.

"Global": [
"^globally restricted pattern"
],
Expand Down
12 changes: 12 additions & 0 deletions artifacts/linting_rules/.spectral.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# - 19.03.2024: Corrected camara-http-methods rule
# - 03.12.2024: Corrected camara-path-param-id and camara-discriminator-use to handle null values error in example fields
# - 09.01.2025: Updated info-contact rule
# - 21.07.2025: Added camara-schema-type-check rule


extends: "spectral:oas"
Expand Down Expand Up @@ -267,3 +268,14 @@ rules:
functionOptions:
match: "^\/([a-z0-9]+(-[a-z0-9]+)*)?(\/[a-z0-9]+(-[a-z0-9]+)*|\/{.+})*$" # doesn't allow /asasd{asdas}sadas pattern or not closed braces
recommended: true # Set to true/false to enable/disable this rule

camara-schema-type-check:
message: "Invalid type in schema definition."
severity: error
given: "$.components.schemas.*"
then:
field: type
function: pattern
functionOptions:
match: "^(string|number|integer|boolean|array|object)$"
recommended: true