Skip to content

Conversation

@rartych
Copy link
Contributor

@rartych rartych commented Jul 21, 2025

What type of PR is this?

  • cleanup

What this PR does / why we need it:

no-restricted-patterns is switched off in gherkinlint
Added camara-schema-type-check rule in Spectral ruleset

Which issue(s) this PR fixes:

Fixes #495

Does this PR introduce a breaking change?

  • Yes
  • No

Special notes for reviewers:

Verifying if type parameter is missing is not trivial - preparing correct rule needs further investigation

Changelog input

Linting rules update

Additional documentation

Copy link
Contributor

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"file-name": ["off", {"style": "kebab-case"}],
"max-scenarios-per-file": ["on", {"maxScenarios": 50, "countOutlineExamples": true}],
"no-restricted-patterns": ["on", {
"no-restricted-patterns": ["off", {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we could remove the problematic patterns but I don't find the rest of patterns specially relevant for us now, so OK to disable it. If we find some interesting pattern to consider in the future we can adjust again the rule.

Copy link
Contributor

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych merged commit ee484e1 into camaraproject:main Jul 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'no-restricted-patterns' in gherkinlint

3 participants