-
Notifications
You must be signed in to change notification settings - Fork 30
Linting rules update #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting rules update #502
Conversation
patrice-conil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| "file-name": ["off", {"style": "kebab-case"}], | ||
| "max-scenarios-per-file": ["on", {"maxScenarios": 50, "countOutlineExamples": true}], | ||
| "no-restricted-patterns": ["on", { | ||
| "no-restricted-patterns": ["off", { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, we could remove the problematic patterns but I don't find the rest of patterns specially relevant for us now, so OK to disable it. If we find some interesting pattern to consider in the future we can adjust again the rule.
jlurien
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
What this PR does / why we need it:
no-restricted-patternsis switched off in gherkinlintAdded
camara-schema-type-checkrule in Spectral rulesetWhich issue(s) this PR fixes:
Fixes #495
Does this PR introduce a breaking change?
Special notes for reviewers:
Verifying if type parameter is missing is not trivial - preparing correct rule needs further investigation
Changelog input
Additional documentation