Skip to content

Conversation

@wuhonglin
Copy link
Contributor

api info

What type of PR is this?

Add one of the following kinds:

  • bug
  • correction
  • enhancement/feature
  • cleanup
  • documentation
  • subproject management
  • tests

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

@wuhonglin wuhonglin requested a review from HanbaiWang as a code owner March 13, 2024 07:28
Copy link
Collaborator

@HanbaiWang HanbaiWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,thanks Honglin

@HanbaiWang HanbaiWang merged commit d589172 into camaraproject:main Mar 13, 2024
@hdamker
Copy link
Contributor

hdamker commented Mar 13, 2024

@HanbaiWang It looks like that this PR was merged without any discussion and review within the sub project. As a codeowner you should ensure that the sub project participants had sufficient time to review and comment the proposed material before it get merged. A good practice would be to discuss in at least one public meeting of the sub project before it get merged.

Without having done a review, the document has at least several issues, for example:

@HanbaiWang
Copy link
Collaborator

@HanbaiWang It looks like that this PR was merged without any discussion and review within the sub project. As a codeowner you should ensure that the sub project participants had sufficient time to review and comment the proposed material before it get merged. A good practice would be to discuss in at least one public meeting of the sub project before it get merged.

Without having done a review, the document has at least several issues, for example:

Thanks for your kindly remind and instruction,this is my first time participating in an open-source community project, and there are many things I'm unclear about. We will pay attention to these issues and make corrections in our subsequent work. Really appreciate your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants