Skip to content

Conversation

@seekwain
Copy link
Contributor

What type of PR is this?

** documentation**

What this PR does / why we need it:

We add API yaml files via upload.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

@seekwain seekwain requested a review from HanbaiWang as a code owner March 13, 2024 09:09
Copy link
Collaborator

@HanbaiWang HanbaiWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click to Dial v1.0 yaml code, thanks for the contribution from Yu Liu.

@HanbaiWang HanbaiWang merged commit 31dac5b into camaraproject:main Mar 13, 2024
@hdamker
Copy link
Contributor

hdamker commented Mar 13, 2024

@seekwain @HanbaiWang Great to see an initial seed contribution here in the sub project. But has this contribution got any community feedback so far? I suppose that 10 minutes between creation and merge of the PR are not sufficient for that.

Please have a view on the chapter "Changes and contributions to CAMARA" within the ProjectStructureAndRoles.md.

I would also recommend not to starting with a version 1.0.0 which suggest that the first release is already stable and will have no breaking changes going forward (e.g. due to community feedback) but allow some development after the initial release (by choosing a 0.x version number).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants