Skip to content
This repository was archived by the owner on May 21, 2021. It is now read-only.

Conversation

@calmondev
Copy link
Owner

@calmondev calmondev commented Dec 21, 2020

This PR is a continuation of the #3. It introduces tests for global object identification and also a few changes.

I noticed that most people weren't actually using the boilerplate but copying-and-pasting files. That wasn't actually my initial idea and for that reason I decided to remove the product module from the source. It will allow anyone to use the boilerplate following the docs to create their own modules (domain based).

@calmondev calmondev marked this pull request as ready for review December 22, 2020 14:57
@calmondev calmondev self-assigned this Dec 22, 2020
@calmondev calmondev added the enhancement New feature or request label Dec 22, 2020
@calmondev calmondev merged commit 58a14c0 into main Dec 22, 2020
@calmondev calmondev deleted the feature/test-goi branch December 26, 2020 12:52
@calmondev calmondev mentioned this pull request Dec 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants