This repository was archived by the owner on May 21, 2021. It is now read-only.
feat: tests #3
Merged
feat: tests #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calmondev
added a commit
that referenced
this pull request
Dec 22, 2020
This PR is a continuation of the #3. It introduces tests for global object identification and also a few changes. I noticed that most people weren't actually *using* the boilerplate but copying-and-pasting files. That wasn't actually my initial idea and for that reason I decided to remove the product module from the source. It will allow anyone to use the boilerplate following the docs to create their own modules (domain based).
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces tests for:
Global Object Identificationis going to be implemented in another PR. It's necessary to change some files for this and I don't want this PR to go out of scope (more than it already did).I will also create another PR to improve the documentation with everything that changed and explaining how to get started using the boilerplate.