forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 30
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix Animate.sequence restart issues (facebook#44031)
Summary: Currently, if the `Animated.sequence` animation is finished, and then the `start()` method is called without a `reset()` method being invoked beforehand, the failure happens: ```undefined is not an object (evaluating 'animations[current].start')```. Use cases: - sequence animation started, finished, and then started again - sequence animation is used in `Animation.loop` with `resetBeforeIteration` set to `false`, which essentially does the same as the previous case Related issues: - facebook#43120 - facebook#37611 ## Changelog: [General] [Fixed] - Fix sequence restart failure Pull Request resolved: facebook#44031 Test Plan: Test cases are included: 1 for regression and 2 for mentioned use cases in the summary Reviewed By: cipolleschi Differential Revision: D56015346 Pulled By: dmytrorykun fbshipit-source-id: 8b0f46c8a33397fece807634463ce630c89d28af
- Loading branch information
1 parent
3c5a3e0
commit a93a15a
Showing
2 changed files
with
68 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters