Fix Animate.sequence restart issues #44031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@dmytrorykun merged this pull request in a93a15a. |
|
This pull request was successfully merged by @asyler in a93a15a. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Currently, if the `Animated.sequence` animation is finished, and then the `start()` method is called without a `reset()` method being invoked beforehand, the failure happens: ```undefined is not an object (evaluating 'animations[current].start')```. Use cases: - sequence animation started, finished, and then started again - sequence animation is used in `Animation.loop` with `resetBeforeIteration` set to `false`, which essentially does the same as the previous case Related issues: - facebook#43120 - facebook#37611 ## Changelog: [General] [Fixed] - Fix sequence restart failure Pull Request resolved: facebook#44031 Test Plan: Test cases are included: 1 for regression and 2 for mentioned use cases in the summary Reviewed By: cipolleschi Differential Revision: D56015346 Pulled By: dmytrorykun fbshipit-source-id: 8b0f46c8a33397fece807634463ce630c89d28af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently, if the
Animated.sequenceanimation is finished, and then thestart()method is called without areset()method being invoked beforehand, the failure happens:undefined is not an object (evaluating 'animations[current].start').Use cases:
Animation.loopwithresetBeforeIterationset tofalse, which essentially does the same as the previous caseRelated issues:
undefined is not an object (evaluating 'animations[current].start')#43120Changelog:
[General] [Fixed] - Fix sequence restart failure
Test Plan:
Test cases are included: 1 for regression and 2 for mentioned use cases in the summary