Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Conflicting states for accessibility and non-accessibility users #354

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
avoid conflicting disabled states
It would be better to show that both these properties can be used separately without fear of another.
#354 (comment)
  • Loading branch information
fabOnReact committed Feb 28, 2022
commit 8a8436e51f0f5a07b130b18212d17d0d8a71ae85
15 changes: 8 additions & 7 deletions example/SliderExample.js
Original file line number Diff line number Diff line change
Expand Up @@ -227,13 +227,14 @@ export const examples = [
title: 'Disabled slider',
platform: 'android',
render(): Element<any> {
return (
<SliderExample
disabled
accessibilityState={{disabled: false}}
value={0.6}
/>
);
return <SliderExample disabled value={0.6} />;
},
},
{
title: 'Slider with accessibilityState disabled',
platform: 'android',
render(): Element<any> {
return <SliderExample disabled value={0.6} />;
},
},
];