Fix: Conflicting states for accessibility and non-accessibility users

[fabOnReact]

Summary:

This issue fixes facebook/react-native#30939 fixes facebook/react-native#30840 (Test Case 7.1, Test Case 7.3, Test Case 7.5) .
The issue is caused by the missing prop accessibilityState in the Slider component.

The solution consists of passing the accessibilityState to the RCTSliderNativeComponent component as previously implemented in other components (for example, Button).

Relevant discussions facebook/react-native#30840 (comment) and https://github.com/facebook/react-native/pull/31001/files#r578827409.

The solution proposed in this pull request consists of:

1. removing the disabled default prop (related discussions fabOnReact@fc9f0c4 and fabOnReact/react-native@afb7fc2).
2. If the value of prop accessibilityState.disabled is different from the prop disabled, the prop disabled over-rides the accessibilityState.disabled value.

For example:

<Slider disabled={true} accessibilityState={{disabled: false}} />

becomes:

<Slider disabled={true} accessibilityState={{disabled: true}} />

3. Remove the existing Android java logic

An alternative Solution published in this branch would be:

• not removing the default prop for disabled (false).
• disabled default prop false over-rides accessibilityState.disabled

This alternative solution would not respect the requirement of not having conflicting states for accessibility and non-accessibility users and the approach adopted in react-native Components (for ex. Button).

For example:

<Slider accessibilityState={{disabled: true}} />

would become (as the deafult is disabled={false})

<Slider accessibilityState={{disabled: false}} />

ADDITIONAL NOTES

• <Slider disabled={"true"} /> triggers a wrong type warning with typescript.
• <Slider disabled={"true"} /> does not trigger a wrong type warning with flow.js.

Test Plan:

Android:

1. Slider has disabled and accessibilityState={{disabled: false}}
2. Slider has disabled
3. Slider has accessibilityState={{disabled: true}}
4. Slider has accessibilityState={{disabled:false}}
5. Slider has disabled={false} and accessibilityState={{disabled:true}}
7. Test Cases on the main branch
7.1. Slider has disabled and accessibilityState={{disabled: false}}
7.3 Slider has accessibilityState={{disabled: true}}
7.5 Slider has disabled={false} and accessibilityState={{disabled:true}}
7.6 Wrong prop type disabled="not a boolean value" with typescript
7.7 Wrong prop type disabled="not a boolean value" with flow on the master branch

[fabOnReact]

TO-DO

• Test Android
• Test iOS

[BartoszKlonowski]

Thank you, @fabriziobertoglio1987! 👍
Looking forward to have this improvement - can you let me know if you plan to continue (making it ready to be reviewed)?

Also: Let me know if you need help with testing it on iOS (of course it's all Java implementation, but we will need to check if changing the JS layer affected other platforms).

[fabOnReact]

Thanks a lot @BartoszKlonowski
I plan to continue. I will test iOS and then move this pull request to Ready to Review.

Thanks a lot
I wish you a good weekend 🙏

[BartoszKlonowski]

Good work in general, thank you! 👍
The only remark I have is to create separate examples and it should be ready to deliver.

[BartoszKlonowski]

Thank you, @fabriziobertoglio1987!