fix(text-input): parent scroll with text input height#4422
Merged
lukewalczak merged 1 commit intocallstack:mainfrom Jul 27, 2024
Merged
Conversation
|
Hey @seb-zabielski, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
Contributor
|
LGTM |
gedu
approved these changes
Jun 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platform: Android only
Motivation
This pull request fixes two bugs that are related to each other.
mode="outlined"withheightstyle property blocks parent scroll.Screen.Recording.2024-05-28.at.11.50.53.mov
mode="outlined"Left/right suffix is not correctly aligned to input when height style is providedmode="flat"(default) blocks scrolling of the parent with a large font. The bug can be reproduced in the example app “Flat input large font”.Screen.Recording.2024-05-28.at.12.23.36.mov
Related issue
#1556, #4390,
Test plan
heightstyle of the Text input propFlat input large fontRecording below shows result with the fix:
Screen.Recording.2024-05-28.at.12.32.25.mov