Skip to content

fix: animation speed for checkbox on Android #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trancever merged 1 commit into from
Nov 14, 2019
Merged

fix: animation speed for checkbox on Android #1471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/components/CheckboxAndroid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ type State = {
scaleAnim: Animated.Value;
};

// From https://material.io/design/motion/speed.html#duration
const ANIMATION_DURATION = 100;

/**
* Checkboxes allow the selection of multiple options from a set.
* This component follows platform guidelines for Android.
Expand Down Expand Up @@ -65,14 +68,18 @@ class CheckboxAndroid extends React.Component<Props, State> {
}

const checked = this.props.status === 'checked';
const { animation } = this.props.theme;

Animated.sequence([
Animated.timing(this.state.scaleAnim, {
toValue: 0.85,
duration: checked ? 200 : 0,
duration: checked ? ANIMATION_DURATION * animation.scale : 0,
}),
Animated.timing(this.state.scaleAnim, {
toValue: 1,
duration: checked ? 200 : 350,
duration: checked
? ANIMATION_DURATION * animation.scale
: ANIMATION_DURATION * animation.scale * 1.75,
}),
]).start();
}
Expand Down