fix: animation speed for checkbox on Android #1471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
animation speed is now adjusted by theme.animation.scale default animation speed changed from 200 to 100ms to comply with https://material.io/design/motion/speed.html#duration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkbox.android now has a faster animation in accordance with the material docs https://material.io/design/motion/speed.html#duration (lowered from 200 to 100).
The animation speed is now also scaled by
theme.animation.scaleFixes issue #1467
Motivation
Test plan
Set
theme.animation.scale = 10to se a really slow Checkbox.android in action