Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): 🌟 add support for React Native 0.73 #736

Merged
merged 5 commits into from
Aug 23, 2023
Merged

feat(android): 🌟 add support for React Native 0.73 #736

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7ac7aee
feat(android): 🌟 add support for React Native 0.73
ngocle2497 Jun 19, 2023
8c21be8
Rollback AndroidManifest.xml to support RN <0.71
ngocle2497 Jun 21, 2023
8fb5e56
feat(all): add namespace when ANDROID_GRADLE_PLUGIN_VERSION >=7
ngocle2497 Jun 21, 2023
2c6775b
Add support RN < 0.71
ngocle2497 Jun 21, 2023
8c0a896
Update android/build.gradle
troZee Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,32 @@ def getExtOrDefault(name) {
def getExtOrIntegerDefault(name) {
return rootProject.ext.has(name) ? rootProject.ext.get(name) : (project.properties['PagerView_' + name]).toInteger()
}
def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION.tokenize('.')[0].toInteger()
troZee marked this conversation as resolved.
Show resolved Hide resolved
def shouldUseNameSpace = agpVersion >= 7
troZee marked this conversation as resolved.
Show resolved Hide resolved
def PACKAGE_PROP = "package=\"com.reactnativepagerview\""
def manifestOutFile = file("${projectDir}/src/main/AndroidManifest.xml")
def manifestContent = manifestOutFile.getText()
if(shouldUseNameSpace){
manifestContent = manifestContent.replaceAll(
PACKAGE_PROP,
''
)
} else {
if(!manifestContent.contains("$PACKAGE_PROP")){
manifestContent = manifestContent.replace(
'<manifest',
"<manifest $PACKAGE_PROP "
)
}
}
manifestContent.replaceAll(" ", " ")
manifestOutFile.write(manifestContent)

android {
compileSdkVersion getExtOrIntegerDefault('compileSdkVersion')

if (shouldUseNameSpace){
namespace = "com.reactnativepagerview"
}
defaultConfig {
minSdkVersion getExtOrIntegerDefault('minSdkVersion')
targetSdkVersion getExtOrIntegerDefault('targetSdkVersion')
Expand Down