Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): 🌟 add support for React Native 0.73 #736

Merged
merged 5 commits into from
Aug 23, 2023

Conversation

ngocle2497
Copy link
Contributor

Summary

Starting from React Native v0.73 , all libraries will need to be updated with these two one-liners due to Android Gradle Plugin upgrade
discussions-671

Compatibility

OS Implemented
iOS
Android

@troZee
Copy link
Member

troZee commented Jun 19, 2023

Hello 👋
Thank you for providing a pr. Unfortunately, it will break apps < 71( react-native-community/discussions-and-proposals#671 (comment))

 it's better to don't remove the package directive from the Manifest and add the namespace directive.

Please update your PR regarding the above comment. Thank you 🙏

@troZee troZee self-requested a review June 19, 2023 15:37
Copy link
Member

@troZee troZee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngocle2497
Copy link
Contributor Author

@troZee i updated my PR

android/build.gradle Outdated Show resolved Hide resolved
Co-authored-by: Burak Güner <md.burak.guner@gmail.com>
@troZee troZee enabled auto-merge (squash) August 23, 2023 14:23
@troZee troZee disabled auto-merge August 23, 2023 14:23
@troZee troZee merged commit 45d4530 into callstack:master Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants