fix: use 'all' for fabric components codegen config #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently codegen doesn't generate all required files such as `Android.mk`, `CMakeLists.txt` etc. for fabric when type is set to `components`. so we use `all` for now until this bug is fixed. closes #661
atlj
approved these changes
Dec 4, 2024
2 tasks
Serchinastico
added a commit
to Serchinastico/react-native-builder-bob
that referenced
this pull request
Feb 18, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
<!-- Please provide enough information so that others can review your pull request. --> <!-- Keep pull requests small and focused on a single change. --> ### Summary <!-- What existing problem does the pull request solve? Can you solve the issue with a different approach? --> I'm bringing back the fix implemented in #715. Unfortunately, it was overwritten in #721 so versions 0.48.x of create-react-native-library are failing Android builds for Fabric components. Fixes #767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently codegen doesn't generate all required files such as
Android.mk,CMakeLists.txtetc. for fabric when type is set tocomponents. so we useallfor now until this bug is fixed.closes #661