Skip to content

Commit

Permalink
fix: bring back #715 to fix Android builds for Fabric components (#769)
Browse files Browse the repository at this point in the history
<!-- Please provide enough information so that others can review your
pull request. -->
<!-- Keep pull requests small and focused on a single change. -->

### Summary

<!-- What existing problem does the pull request solve? Can you solve
the issue with a different approach? -->

I'm bringing back the fix implemented in
#715.
Unfortunately, it was overwritten in
#721 so
versions 0.48.x of create-react-native-library are failing Android
builds for Fabric components.

Fixes #767
  • Loading branch information
Serchinastico authored Feb 25, 2025
1 parent 1684036 commit be8b107
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<% if (project.arch === 'new') { -%>
"codegenConfig": {
"name": "RN<%- project.name -%><%- project.viewConfig !== null ? 'View': '' -%>Spec",
"type": <%- project.viewConfig !== null ? '"components"': '"modules"' %>,
"type": <%- project.viewConfig !== null ? '"all"': '"modules"' %>,
"jsSrcsDir": "src"
},
<% } -%>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
<% if (project.moduleConfig === 'nitro-modules') { -%>
"react-native": "*",
"react-native-nitro-modules": "^<%- versions.nitroModules %>"
<% } else { -%>
<% } else { -%>
"react-native": "*"
<% } -%>
},
Expand Down Expand Up @@ -224,7 +224,7 @@
},
"codegenConfig": {
"name": "RN<%- project.name -%><%- project.viewConfig !== null ? 'View': '' -%>Spec",
"type": "<%- project.viewConfig !== null ? 'components': 'modules' -%>",
"type": "<%- project.viewConfig !== null ? 'all': 'modules' -%>",
"jsSrcsDir": "src",
"outputDir": {
"ios": "ios/generated",
Expand Down

0 comments on commit be8b107

Please sign in to comment.