Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rotate- and scale-by-amount methods #108

Merged
merged 3 commits into from
Jun 19, 2018
Merged

Add rotate- and scale-by-amount methods #108

merged 3 commits into from
Jun 19, 2018

Conversation

davepagurek
Copy link
Member

Fixes #90

The tree example no longer needs quaternions and matrices!

throw new Error("Can't scale when more than one point is held!");
}

const anchor =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge nit, but could you please style this ternary assignment like the above one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoformatter just resets it :'(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, gotchu, then :shipit:

Copy link
Member

@armcburney armcburney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, nice work! <3

Copy link
Member

@armcburney armcburney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@davepagurek davepagurek merged commit d46b341 into master Jun 19, 2018
@davepagurek davepagurek deleted the rotate-scale branch June 19, 2018 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants