Skip to content

Database host hardcoded in start.sh #19

Closed
@krumware

Description

The database host is hardcoded to db:5432 instead of leveraging the environmental variables defined in .env. This prevents the service from properly starting in environments where the service address of the database may not be db.

It is possible to modify to /app/scripts/wait-for-it.sh ${DATABASE_HOST} -- echo "db is up" , after which the default .env can be updated to

DATABASE_HOST=db:5432
DATABASE_URL=postgresql://${POSTGRES_USER}:${POSTGRES_PASSWORD}@${POSTGRES_HOST}/${POSTGRES_DB}

This will allow for better runtime configuration in deployed environments.

(will submit PR if this is ok)

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions