Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded database url and add DATABASE_HOST variable #21

Merged
merged 1 commit into from
Oct 23, 2021
Merged

Remove hardcoded database url and add DATABASE_HOST variable #21

merged 1 commit into from
Oct 23, 2021

Conversation

krumware
Copy link
Member

@krumware krumware commented Oct 5, 2021

This allows the startup script to use a runtime variable for control over the database location. Previously, the start.sh script was hardcoded to a specific database url specified by the service name in a docker-compose network.

closes #19

@krumware
Copy link
Member Author

krumware commented Oct 8, 2021

@vanceism7 wondering if you might be able to informally peer-review / try this change

@vanceism7
Copy link

Hey @krumware, don't have my computer on me currently. I'll try to give this a test soon though if no one else has

@vanceism7
Copy link

@krumware - Did we want to test this PR exactly as is or with that modified Docker file you supplied in that issue we were discussing? The change seems pretty straightforward but wanted to confirm this before testing

@krumware
Copy link
Member Author

@vanceism7 either-or, since it's on the compose side.
I have a gut feeling that the quotes may need to be removed from the .env var, but it's working as-PRed for me

@PeerRich
Copy link
Member

has someone tested this? is it working?

Copy link

@vanceism7 vanceism7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it took a while to get to testing this. This is working for me, with the caveat that I had to follow the instructions discussed in #11 (e.g: replace the Dockerfile, remove quotes from the .env file, change yarn start to yarn dev in scripts/start.sh)

Since this change has strictly to do with the database env variables and not any of the issues specifically coming from #11, I'll give this my approval (although it should be noted that I'm not associated with this project in any official capacity).

@krumware
Copy link
Member Author

krumware commented Oct 14, 2021

that was the goal, to keep it small and on topic.
I'm waiting to see if there's any movement on removing the postgres requirement from the build before I'm able to finish the other docker pieces and will include a good number of polishing changes in a separate PR for that

@kelvinalfaro
Copy link
Contributor

This worked for me too.

Copy link
Contributor

@kelvinalfaro kelvinalfaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes worked for me

@emrysal emrysal merged commit 9d8802b into calcom:main Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database host hardcoded in start.sh
5 participants