-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hardcoded database url and add DATABASE_HOST variable #21
Conversation
@vanceism7 wondering if you might be able to informally peer-review / try this change |
Hey @krumware, don't have my computer on me currently. I'll try to give this a test soon though if no one else has |
@krumware - Did we want to test this PR exactly as is or with that modified Docker file you supplied in that issue we were discussing? The change seems pretty straightforward but wanted to confirm this before testing |
@vanceism7 either-or, since it's on the compose side. |
has someone tested this? is it working? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it took a while to get to testing this. This is working for me, with the caveat that I had to follow the instructions discussed in #11 (e.g: replace the Dockerfile, remove quotes from the .env file, change yarn start
to yarn dev
in scripts/start.sh
)
Since this change has strictly to do with the database env variables and not any of the issues specifically coming from #11, I'll give this my approval (although it should be noted that I'm not associated with this project in any official capacity).
that was the goal, to keep it small and on topic. |
This worked for me too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes worked for me
This allows the startup script to use a runtime variable for control over the database location. Previously, the start.sh script was hardcoded to a specific database url specified by the service name in a docker-compose network.
closes #19