Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: open cal video url on new page when ready #19683

Merged
merged 6 commits into from
Mar 5, 2025
Merged

fix: open cal video url on new page when ready #19683

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
53d3a90
fix: open cal video url on new page when ready
Udit-takkar Mar 3, 2025
1bb3629
fix: open on new tab
Udit-takkar Mar 4, 2025
3031ee5
chore: change logic
Udit-takkar Mar 4, 2025
85a8ee9
chore: add condition for embed
Udit-takkar Mar 4, 2025
5bb2dbb
Merge branch 'main' into fix/open-on-new-page
PeerRich Mar 5, 2025
8539cd4
chore: simplify the code
Udit-takkar Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: open on new tab
  • Loading branch information
@Udit-takkar
Udit-takkar committed Mar 4, 2025
commit 1bb3629b357d7d9387834de03364a139ca9f67b5
2 changes: 1 addition & 1 deletion packages/features/bookings/Booker/components/RedirectToInstantMeetingModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export const RedirectToInstantMeetingModal = ({
useEffect(() => {
if (!!instantVideoMeetingUrl) {
window.removeEventListener("beforeunload", handleBeforeUnload);
window.open(instantVideoMeetingUrl, "_blank", "noopener,noreferrer");
router.push(instantVideoMeetingUrl);
}
}, [instantVideoMeetingUrl]);

Expand Down
4 changes: 3 additions & 1 deletion packages/platform/atoms/booker/BookerWebWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,9 @@ export const BookerWebWrapper = (props: BookerWebWrapperAtomProps) => {
}}
onConnectNowInstantMeeting={() => {
const newPath = `${pathname}?isInstantMeeting=true`;
router.push(newPath);
// Open in a new tab instead of using router.push
const fullUrl = window.location.origin + newPath;
window.open(fullUrl, "_blank");
}}
onOverlayClickNoCalendar={() => {
router.push("/apps/categories/calendar");
Expand Down
Loading