fix: open cal video url on new page when ready #19683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
keithwillcode
added
core
Udit-takkar
commented
Mar 4, 2025
Comment on lines
204
to
212
|
|
||
| const baseUrl = window.location.href.split("?")[0].split("#")[0]; | ||
|
|
||
| const baseUrlWithoutPath = baseUrl.split("/").slice(0, 3).join("/"); | ||
| const fullUrl = newPath.startsWith("/") | ||
| ? `${baseUrlWithoutPath}${newPath}` | ||
| : `${baseUrlWithoutPath}/${newPath}`; | ||
|
|
||
| window.open(fullUrl, "_blank", "noopener,noreferrer"); |
There was a problem hiding this comment.
Open on new tab when user clicks on "connect now"
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (03/04/25)1 reviewer was added to this PR based on Keith Williams's automation. |
PeerRich
previously approved these changes
Mar 4, 2025
hariombalhara
requested changes
Mar 5, 2025
hariombalhara
approved these changes
Mar 5, 2025
E2E results are ready! |
ThyMinimalDev
pushed a commit
that referenced
this pull request
Mar 5, 2025
* fix: open cal video url on new page when ready * fix: open on new tab * chore: change logic * chore: add condition for embed * chore: simplify the code --------- Co-authored-by: Peer Richelsen <peeroke@gmail.com>
itsalam
pushed a commit
to itsalam/cal.com
that referenced
this pull request
Mar 6, 2025
* fix: open cal video url on new page when ready * fix: open on new tab * chore: change logic * chore: add condition for embed * chore: simplify the code --------- Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
In case of embed we should open it on new tab.