-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: failing scheduleEmailReminder cron job #11960
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 162 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/18/2023 08:13:39am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 82d2b11 Started: 10/18/2023 08:11:04am UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Can delete user account
Retry 1 • Initial Attempt |
1.01% (3)3 / 298 runsfailed over last 7 days |
10.74% (32)32 / 298 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
3.37% (10)10 / 297 runsfailed over last 7 days |
45.45% (135)135 / 297 runsflaked over last 7 days |
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
9.12% (27)27 / 296 runsfailed over last 7 days |
89.53% (265)265 / 296 runsflaked over last 7 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
After #11929 got merged, cron - scheduleEmailReminders is still failing. Now with a new error message:
With this PR we now only select the needed properties when querying workflowReminders, which hopefully helps us to reduce the response size enough