Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failing scheduleEmailReminder cron job #11960

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

CarinaWolli
Copy link
Member

@CarinaWolli CarinaWolli commented Oct 18, 2023

What does this PR do?

After #11929 got merged, cron - scheduleEmailReminders is still failing. Now with a new error message:

PrismaClientKnownRequestError: 
Invalid `prisma.workflowReminder.findMany()` invocation:

This request could not be understood by the server: {"type":"UnknownJsonError","body":{"code":"P6009","message":"The response size of the query exceeded the the maximum of 5MB with 15.07MB. Consider refining the query by narrowing the selection set or applying appropriate filters. If that is not acceptable for your use case, please contact Prisma support."}} 

With this PR we now only select the needed properties when querying workflowReminders, which hopefully helps us to reduce the response size enough

@CarinaWolli CarinaWolli added the High priority Created by Linear-GitHub Sync label Oct 18, 2023
@CarinaWolli CarinaWolli requested a review from zomars October 18, 2023 08:03
@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview Oct 18, 2023 8:05am
api ✅ Ready (Inspect) Visit Preview Oct 18, 2023 8:05am
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 8:05am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 8:05am
ui ✅ Ready (Inspect) Visit Preview Oct 18, 2023 8:05am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Oct 18, 2023 8:05am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link

deploysentinel bot commented Oct 18, 2023

Current Playwright Test Results Summary

✅ 162 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/18/2023 08:13:39am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 82d2b11

Started: 10/18/2023 08:11:04am UTC

⚠️ Flakes

📄   apps/web/playwright/auth/delete-account.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Can delete user account
Retry 1Initial Attempt
1.01% (3) 3 / 298 runs
failed over last 7 days
10.74% (32) 32 / 298 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
3.37% (10) 10 / 297 runs
failed over last 7 days
45.45% (135) 135 / 297 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
9.12% (27) 27 / 296 runs
failed over last 7 days
89.53% (265) 265 / 296 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CarinaWolli CarinaWolli merged commit 0c92fbe into main Oct 18, 2023
@CarinaWolli CarinaWolli deleted the fix/scheduleEmailreminder-response branch October 18, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only High priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants