Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scheduleEmailReminders cron job #11929

Merged
merged 3 commits into from
Oct 17, 2023
Merged

fix: scheduleEmailReminders cron job #11929

merged 3 commits into from
Oct 17, 2023

Conversation

CarinaWolli
Copy link
Member

What does this PR do?

Attempt to fix failing github action Cron-scheduleEmailReminders (https://github.com/calcom/cal.com/actions/workflows/cron-scheduleEmailReminders.yml) --> currently disabled

Axiom error:

PrismaClientKnownRequestError: 
Invalid `prisma.workflowReminder.findMany()` invocation:

This request could not be understood by the server: {"type":"UnknownJsonError","body":{"code":"P6004","message":"The Query did not produce a result within the maximum allowed execution time of 10 seconds."}}

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 7:00am
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 7:00am
cal 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 7:00am
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 7:00am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 7:00am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 7:00am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
qa ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2023 7:00am

@github-actions github-actions bot added the ❗️ migrations contains migration files label Oct 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@zomars zomars added the core area: core, team members only label Oct 17, 2023
},
},
});
skip: pageNumber * pageSize,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

load workflowReminders in batches (we also do that in api/crondowngradeUsers and api/cron/monthlyDigestEmail)

@CarinaWolli CarinaWolli added the High priority Created by Linear-GitHub Sync label Oct 17, 2023
@CarinaWolli CarinaWolli added the Urgent Created by Linear-GitHub Sync label Oct 17, 2023
@CarinaWolli CarinaWolli requested a review from zomars October 17, 2023 06:48
@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link

deploysentinel bot commented Oct 17, 2023

Current Playwright Test Results Summary

✅ 162 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/17/2023 07:01:06am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: dceb828

Started: 10/17/2023 06:57:56am UTC

⚠️ Flakes

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams Profile page is loaded for users in Organization
Retry 2Retry 1Initial Attempt
1.49% (4) 4 / 269 runs
failed over last 7 days
30.48% (82) 82 / 269 runs
flaked over last 7 days

📄   apps/web/playwright/change-username.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Change username on settings User can change username
Retry 1Initial Attempt
1.44% (4) 4 / 278 runs
failed over last 7 days
25.18% (70) 70 / 278 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
9.03% (26) 26 / 288 runs
failed over last 7 days
89.58% (258) 258 / 288 runs
flaked over last 7 days
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
3.81% (11) 11 / 289 runs
failed over last 7 days
35.64% (103) 103 / 289 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find @CarinaWolli

LGTM

@zomars zomars merged commit 4b8bdeb into main Oct 17, 2023
@zomars zomars deleted the fix/scheduleEmailReminder branch October 17, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only High priority Created by Linear-GitHub Sync ❗️ migrations contains migration files Urgent Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants