-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add usermod command about default username #26
add usermod command about default username #26
Conversation
cmdUsermod supports changing the default username in case any extra initial state needs updated, cmdUsermod can be amended to run additional commands
d88c9f8
to
a2fae60
Compare
Overall this looks reasonable, but I'd like to test it out. My two main worries here are:
I'll get back when I've tested these two. Thanks for fixing this one! |
I looked at this; the current |
Could I ask that you please build and run your commits? I just built it and the install fails because it's trying to change the user's password before creating that user. |
Just tested it, this isn't an issue. |
@Undef-a, @adriaandegroot -- I have confirmed that these changes resolve #25, completing the desires of #22. In Mobian, where I tested, the user's full-name is still "mobian" I believe; I don't know if this is behavior of Mobian or of the mobile module: if the latter, this could be updated to change the full-name to match the given username. As noted above, the new |
Just got the chance to test this. It's working pretty much as expected now. As for the fullname, Thanks for fixing this one up! It's very nearly there. |
With that last commit LGTM. After install I have a newly named user with no sight of "Mobian" anywhere. Thanks. |
We need to make sure |
Thank you. Sorry for the break. |
I've just verified that this also fixes the bug on postmarketOS, and creating the user with a custom username works. Thanks for fixing it @nmschulte! @adriaandegroot: can you please tag a fixup release? |
Backport patches to fix a regression from the 1.3.0 release that cause the mobile installer to be stuck at the "new user" screen. Related: calamares/calamares-extensions#26 Related: calamares/calamares-extensions#25
attempts to fix #25