-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add username prompt, reservedUsernames config, minor cleanup #22
add username prompt, reservedUsernames config, minor cleanup #22
Conversation
99e3ab5
to
bed3287
Compare
bed3287
to
f40e7cf
Compare
I don't have a particular comment to make here, since the module is mobile-(mobian)specific and I don't feel qualified to comment. Maybe @ollieparanoid or @PureTryOut ? Those are Postmarket folks, I think. I don't know what the source is of the reserved names. It seems to contain a bunch that I wouldn't call reserved in the context of a general OS (cyrus, for instance, unless cyrus imap is always on the system). Moving the reserved list to C++ makes it much harder to adapt to whatever mobile OS is using this module, though. |
It seems fine, although I agree on the reserved usernames comment. |
I'll fix the TODO about the validation. Any thoughts about the placeholder TODO? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f40e7cf
to
82f31f3
Compare
I created this work for Mobian, and as suggested am sharing here for review and inclusion. A question is open about where the reserved usernames list comes from; see https://salsa.debian.org/Mobian-team/packages/calamares-extensions/-/merge_requests/4.