Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Up PyPI Upload Process #3208

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Conversation

SorenSpicknall
Copy link
Contributor

@SorenSpicknall SorenSpicknall commented Jan 3, 2024

Description

Upon merge of #3204, publication to PyPI was unsuccessful for the calitp-data-infra package (it was skipped for calitp-data-analysis because the current version number matched the published version number). This PR makes a change to a mistyped environment variable assignment in the publication YML for calitp-data-analysis which should resolve the issue based on my understanding of Poetry's environment variable construction norms. If not, there is an additional step we can take next.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Uploads made to TestPyPI based on similar environment variable structure - since this workflow only fires to prod upon merge, if this set of changes doesn't work an additional PR will be created for the next set of changes.

Post-merge follow-ups

  • No action required
  • Actions required (specified below)

@SorenSpicknall SorenSpicknall changed the title DRAFT: Fix Up PyPI Upload Process Fix Up PyPI Upload Process Jan 3, 2024
@SorenSpicknall SorenSpicknall marked this pull request as ready for review January 3, 2024 21:23
Copy link
Member

@charlie-costanzo charlie-costanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SorenSpicknall SorenSpicknall merged commit 75e952a into main Jan 4, 2024
2 checks passed
@SorenSpicknall SorenSpicknall deleted the soren-pypi_publication_patchup branch January 4, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants