Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move setup-gcloud to floating V2 release #3204

Merged
merged 6 commits into from
Jan 3, 2024

Conversation

SorenSpicknall
Copy link
Contributor

@SorenSpicknall SorenSpicknall commented Jan 2, 2024

Description

Resolves #3203 by upgrading the google-github-actions/setup-gcloud Action to use a supported version, which also required adding the google-github-actions/auth action since the current version of setup-gcloud cleaves away authentication.

Additionally, moves our linting step back to use Python 3.11.7 instead of 3.12 due to PEP 632 impacting an underlying tool that we don't have direct control over.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Many of the relevant workflows were tested automatically within this PR. Changes made in the others are identical, and those workflows have access to the same creds, so no differing behavior is expected.

Post-merge follow-ups

  • No action required
  • Actions required (specified below)

@SorenSpicknall SorenSpicknall changed the title DRAFT: Move setup-gcloud to floating V2 release Move setup-gcloud to floating V2 release Jan 2, 2024
@SorenSpicknall SorenSpicknall marked this pull request as ready for review January 2, 2024 20:42
@SorenSpicknall SorenSpicknall mentioned this pull request Jan 3, 2024
5 tasks
Copy link
Member

@charlie-costanzo charlie-costanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you for taking care of this!

@SorenSpicknall SorenSpicknall merged commit e2d956f into main Jan 3, 2024
6 checks passed
@SorenSpicknall SorenSpicknall deleted the soren-update_setup_gcloud_action branch January 3, 2024 18:08
@SorenSpicknall SorenSpicknall mentioned this pull request Jan 3, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade setup-gcloud in GitHub Actions
2 participants