fix(config): preserve unknown config keys on save - #1675
Merged
Conversation
Keep a copy of the last loaded config JSON and merge unknown keys back into the serialized output before writing it to disk. This prevents the config save workflow from pruning unsupported or future options while still allowing known config properties to be updated normally.
YashMahawa
pushed a commit
to YashMahawa/shell
that referenced
this pull request
Jul 23, 2026
Keep a copy of the last loaded config JSON and merge unknown keys back into the serialized output before writing it to disk. This prevents the config save workflow from pruning unsupported or future options while still allowing known config properties to be updated normally. Co-authored-by: 2 * r + 2 * t <61896496+soramanew@users.noreply.github.com>
DaveLewis360
added a commit
to DaveLewis360/shell
that referenced
this pull request
Jul 30, 2026
* upstream/main: fix: use GNUInstallDirs for install dirs (caelestia-dots#1762) fix: fp precision for nexus fix: nominatim compliance (caelestia-dots#1752) [CI] chore: update flake fix: repeated low battery warnings (caelestia-dots#1477) refactor: change IP-lookup API + handle retry on rate limited (caelestia-dots#1734) fix: eager load certain services (caelestia-dots#1733) feat: add utilities panel confs to nexus (caelestia-dots#1725) [CI] chore: update flake fix: file system model sorting fix: fully round toggled network filter chips feat: add saved networks sub page to nexus (caelestia-dots#1722) feat: cap networks shown in nexus (caelestia-dots#1719) fix: nexus network null warnings fix: battery time calc feat: nexus VPN section with provider management (caelestia-dots#1605) fix: add qtimageformats to nix qs dep (caelestia-dots#1716) ci: add nix build workflow (caelestia-dots#1715) fix: handle > INT_MAX player lengths overflowing in lyrics (caelestia-dots#1648) feat: hidden networks, per-network settings and IPv4 config (caelestia-dots#1604) fix: key ZFS filesystems by pool in storage service (caelestia-dots#1673) fix: support delayed "xesam:artist" for now playing toast (caelestia-dots#1700) fix: preserve unknown config keys on save (caelestia-dots#1675) fix: populate pipewire nodes immediately (caelestia-dots#1699) fix: launcher action searching (caelestia-dots#1695) chore: fix lint warnings (caelestia-dots#1705) [CI] chore: update flake [CI] chore: update flake fix: improve compact tray styling refactor: use Item instead of Loader for bar entries (caelestia-dots#1663) refactor: improve state handling & add component hooks (caelestia-dots#1661) fix: ethernet devices incorrect end rounding fix: text field outline outside of widget bounds feat: add lock howdy support (caelestia-dots#1515) fix: don't animate calendar today indicator chore: remove unused Tooltip component fix: menu/popup overlays overriding cursor shape feat: improve text controls (caelestia-dots#1647) # Conflicts: # modules/bar/Bar.qml # modules/bar/BarWrapper.qml # modules/bar/components/Tray.qml # modules/drawers/ContentWindow.qml # modules/drawers/Interactions.qml # modules/drawers/Panels.qml # modules/lock/NotifGroup.qml # services/Players.qml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve unknown keys from the loaded
shell.jsonwhen saving config, then merge unknown keys back into the serialized output. This prevents the shell from removing unknown keys in the config, which can be an issue when keys for features that are in development are present, or for configurations designed for forks that are loaded during a build of the upstream shell. Known Qt-meta properties are still authoritative, so normal edits and resets continue to work as expected.Testing