should use 'return X' instead of 'if X { return true }; return false'…

… (S1008)

common/elasticsearch/client_v6.go

@@ -81,10 +81,7 @@ type (
 )
 
 func (c *elasticV6) IsNotFoundError(err error) bool {
-	if elastic.IsNotFound(err) {
-		return true
-	}
-	return false
+	return elastic.IsNotFound(err)
 }
 
 // NewV6Client returns a new implementation of GenericClient

common/elasticsearch/client_v7.go

@@ -155,10 +155,7 @@ func buildSigningHTTPClientFromEnvironmentCredentialV7(credentialConfig config.A
 }
 
 func (c *elasticV7) IsNotFoundError(err error) bool {
-	if elastic.IsNotFound(err) {
-		return true
-	}
-	return false
+	return elastic.IsNotFound(err)
 }
 
 // root is for nested object like Attr property for search attributes.

common/persistence/nosql/nosqlplugin/dynamodb/db.go

@@ -71,8 +71,5 @@ func (db *ddb) IsThrottlingError(err error) bool {
 }
 
 func (db *ddb) IsConditionFailedError(err error) bool {
-	if err == errConditionFailed {
-		return true
-	}
-	return false
+	return err == errConditionFailed
 }

common/persistence/persistence-tests/executionManagerTest.go

@@ -5358,8 +5358,5 @@ func timestampConvertor(t time.Time) time.Time {
 
 func timeComparator(t1, t2 time.Time, timeTolerance time.Duration) bool {
 	diff := t2.Sub(t1)
-	if diff.Nanoseconds() <= timeTolerance.Nanoseconds() {
-		return true
-	}
-	return false
+	return diff.Nanoseconds() <= timeTolerance.Nanoseconds()
 }

common/persistence/sql/sqlplugin/mysql/db.go

@@ -58,10 +58,7 @@ func (mdb *db) IsDupEntryError(err error) bool {
 }
 
 func (mdb *db) IsNotFoundError(err error) bool {
-	if err == sql.ErrNoRows {
-		return true
-	}
-	return false
+	return err == sql.ErrNoRows
 }
 
 func (mdb *db) IsTimeoutError(err error) bool {

common/persistence/sql/sqlplugin/postgres/db.go

@@ -61,17 +61,11 @@ func (pdb *db) IsDupEntryError(err error) bool {
 }
 
 func (pdb *db) IsNotFoundError(err error) bool {
-	if err == sql.ErrNoRows {
-		return true
-	}
-	return false
+	return err == sql.ErrNoRows
 }
 
 func (pdb *db) IsTimeoutError(err error) bool {
-	if err == context.DeadlineExceeded {
-		return true
-	}
-	return false
+	return err == context.DeadlineExceeded
 }
 
 func (pdb *db) IsThrottlingError(err error) bool {

service/history/execution/mutable_state_builder.go

@@ -809,10 +809,7 @@ func (e *mutableStateBuilder) IsStickyTaskListEnabled() bool {
 		return false
 	}
 	ttl := e.config.StickyTTL(e.GetDomainEntry().GetInfo().Name)
-	if e.timeSource.Now().After(e.executionInfo.LastUpdatedTimestamp.Add(ttl)) {
-		return false
-	}
-	return true
+	return !e.timeSource.Now().After(e.executionInfo.LastUpdatedTimestamp.Add(ttl))
 }
 
 func (e *mutableStateBuilder) CreateNewHistoryEvent(

service/history/ndc/replication_task.go

@@ -354,10 +354,7 @@ func validateReplicateEventsRequest(
 }
 
 func validateUUID(input string) bool {
-	if uuid.Parse(input) == nil {
-		return false
-	}
-	return true
+	return uuid.Parse(input) != nil
 }
 
 func validateEvents(events []*types.HistoryEvent) (int64, error) {

service/worker/archiver/pump_test.go

@@ -265,10 +265,7 @@ func channelContainsExpected(ctx workflow.Context, ch workflow.Channel, expected
 			return false
 		}
 	}
-	if ch.Receive(ctx, nil) {
-		return false
-	}
-	return true
+	return !ch.Receive(ctx, nil)
 }
 
 func randomCarryover(count int) ([]ArchiveRequest, []uint64) {