removed unused code (U1000)

cadence-workflow · vytautas-karpavicius · Feb 28, 2022 · Feb 22, 2022 · Feb 22, 2022 · Feb 22, 2022
commit 030d9742bafa60bbf2f3f92be44b5f8795c61d7c
@@ -27,7 +27,6 @@ import (
 	"io"
 	"io/ioutil"
 	"os"
-	"regexp"
 
 	"cloud.google.com/go/storage"
 	"google.golang.org/api/iterator"
@@ -36,15 +35,10 @@ import (
 	"github.com/uber/cadence/common/config"
 )
 
-const (
-	bucketNameRegExpRaw = "^gs:\\/\\/[^:\\/\n?]+"
-)
-
 var (
 	// ErrBucketNotFound is non retriable error that is thrown when the bucket doesn't exist
 	ErrBucketNotFound = errors.New("bucket not found")
 	errObjectNotFound = errors.New("object not found")
-	bucketNameRegExp  = regexp.MustCompile(bucketNameRegExpRaw)
 )
 
 type (

@@ -23,7 +23,6 @@ package connector
 import (
 	"context"
 	"io/ioutil"
-	"os"
 
 	"cloud.google.com/go/storage"
 	"golang.org/x/oauth2/google"
@@ -97,20 +96,8 @@ type (
 	ObjectIteratorWrapper interface {
 		Next() (*storage.ObjectAttrs, error)
 	}
-
-	objectIteratorDelegate struct {
-		iterator *storage.ObjectIterator
-	}
 )
 
-func newClientDelegate() (*clientDelegate, error) {
-	ctx := context.Background()
-	if credentialsPath := os.Getenv("GOOGLE_APPLICATION_CREDENTIALS"); credentialsPath != "" {
-		return newClientDelegateWithCredentials(ctx, credentialsPath)
-	}
-	return newDefaultClientDelegate(ctx)
-}
-
 func newDefaultClientDelegate(ctx context.Context) (*clientDelegate, error) {
 	nativeClient, err := storage.NewClient(ctx)
 	return &clientDelegate{nativeClient: nativeClient}, err
@@ -164,17 +151,6 @@ func (b *bucketDelegate) Attrs(ctx context.Context) (*storage.BucketAttrs, error
 	return b.bucket.Attrs(ctx)
 }
 
-// Next returns the next result. Its second return value is iterator.Done if
-// there are no more results. Once Next returns iterator.Done, all subsequent
-// calls will return iterator.Done.
-//
-// If Query.Delimiter is non-empty, some of the ObjectAttrs returned by Next will
-// have a non-empty Prefix field, and a zero value for all other fields. These
-// represent prefixes.
-func (o *objectIteratorDelegate) Next() (*storage.ObjectAttrs, error) {
-	return o.iterator.Next()
-}
-
 // NewWriter returns a storage Writer that writes to the GCS object
 // associated with this ObjectHandle.
 //

@@ -26,13 +26,11 @@ import (
 	"errors"
 	"fmt"
 	"strconv"
-	"strings"
 	"time"
 
 	"github.com/xwb1989/sqlparser"
 
 	"github.com/uber/cadence/common"
-	"github.com/uber/cadence/common/types"
 )
 
 type (
@@ -233,21 +231,6 @@ func (p *queryParser) convertComparisonExpr(compExpr *sqlparser.ComparisonExpr,
 	return nil
 }
 
-func (p *queryParser) convertCloseTime(timestamp int64, op string, parsedQuery *parsedQuery) error {
-	switch op {
-	case "=":
-		if err := p.convertCloseTime(timestamp, ">=", parsedQuery); err != nil {
-			return err
-		}
-		if err := p.convertCloseTime(timestamp, "<=", parsedQuery); err != nil {
-			return err
-		}
-	default:
-		return fmt.Errorf("operator %s is not supported for close time", op)
-	}
-	return nil
-}
-
 func convertToTimestamp(timeStr string) (int64, error) {
 	timestamp, err := strconv.ParseInt(timeStr, 10, 64)
 	if err == nil {
@@ -264,24 +247,6 @@ func convertToTimestamp(timeStr string) (int64, error) {
 	return parsedTime.UnixNano(), nil
 }
 
-func convertStatusStr(statusStr string) (types.WorkflowExecutionCloseStatus, error) {
-	statusStr = strings.ToLower(statusStr)
-	switch statusStr {
-	case "completed":
-		return types.WorkflowExecutionCloseStatusCompleted, nil
-	case "failed":
-		return types.WorkflowExecutionCloseStatusFailed, nil
-	case "canceled":
-		return types.WorkflowExecutionCloseStatusCanceled, nil
-	case "continuedasnew":
-		return types.WorkflowExecutionCloseStatusContinuedAsNew, nil
-	case "timedout":
-		return types.WorkflowExecutionCloseStatusTimedOut, nil
-	default:
-		return 0, fmt.Errorf("unknown workflow close status: %s", statusStr)
-	}
-}
-
 func extractStringValue(s string) (string, error) {
 	if len(s) >= 2 && s[0] == '\'' && s[len(s)-1] == '\'' {
 		return s[1 : len(s)-1], nil

@@ -50,11 +50,6 @@ func decodeHistoryBatches(data []byte) ([]*types.History, error) {
 	return historyBatches, nil
 }
 
-func constructHistoryFilename(domainID, workflowID, runID string, version int64) string {
-	combinedHash := constructHistoryFilenamePrefix(domainID, workflowID, runID)
-	return fmt.Sprintf("%s_%v.history", combinedHash, version)
-}
-
 func constructHistoryFilenameMultipart(domainID, workflowID, runID string, version int64, partNumber int) string {
 	combinedHash := constructHistoryFilenamePrefix(domainID, workflowID, runID)
 	return fmt.Sprintf("%s_%v_%v.history", combinedHash, version, partNumber)

@@ -68,7 +68,6 @@ type (
 		s3cli     s3iface.S3API
 		// only set in test code
 		historyIterator archiver.HistoryIterator
-		config          *config.S3Archiver
 	}
 
 	getHistoryToken struct {

@@ -46,7 +46,6 @@ import (
 	"github.com/uber/cadence/common"
 	"github.com/uber/cadence/common/archiver"
 	"github.com/uber/cadence/common/archiver/s3store/mocks"
-	"github.com/uber/cadence/common/log"
 	"github.com/uber/cadence/common/log/loggerimpl"
 	"github.com/uber/cadence/common/metrics"
 	"github.com/uber/cadence/common/types"
@@ -73,7 +72,6 @@ type historyArchiverSuite struct {
 	suite.Suite
 	s3cli              *mocks.S3API
 	container          *archiver.HistoryBootstrapContainer
-	logger             log.Logger
 	testArchivalURI    archiver.URI
 	historyBatchesV1   []*archiver.HistoryBlob
 	historyBatchesV100 []*archiver.HistoryBlob

@@ -40,7 +40,6 @@ import (
 	"github.com/uber/cadence/common"
 	"github.com/uber/cadence/common/archiver"
 	"github.com/uber/cadence/common/archiver/s3store/mocks"
-	"github.com/uber/cadence/common/log"
 	"github.com/uber/cadence/common/log/loggerimpl"
 	"github.com/uber/cadence/common/metrics"
 	"github.com/uber/cadence/common/types"
@@ -52,7 +51,6 @@ type visibilityArchiverSuite struct {
 	s3cli *mocks.S3API
 
 	container         *archiver.VisibilityBootstrapContainer
-	logger            log.Logger
 	visibilityRecords []*visibilityRecord
 
 	controller      *gomock.Controller

@@ -67,11 +67,6 @@ type cacheEntry struct {
 	dcEntries     map[string]*types.DynamicConfigEntry
 }
 
-type fetchResult struct {
-	snapshot *persistence.DynamicConfigSnapshot
-	err      error
-}
-
 // NewConfigStoreClient creates a config store client
 func NewConfigStoreClient(clientCfg *csc.ClientConfig, persistenceCfg *config.Persistence, logger log.Logger, doneCh chan struct{}) (dc.Client, error) {
 	if err := validateClientConfig(clientCfg); err != nil {

@@ -21,8 +21,6 @@
 package esql
 
 import (
-	"fmt"
-
 	"github.com/xwb1989/sqlparser"
 )
 
@@ -85,11 +83,3 @@ const (
 	TieBreakerOrder      = "desc"
 	StartTimeOrder       = "desc"
 )
-
-// DEBUG usage
-//nolint
-func print(v interface{}) {
-	fmt.Println("==============")
-	fmt.Println(v)
-	fmt.Println("==============")
-}
@@ -68,7 +68,6 @@ var (
 	testLatestTime   = int64(2547596872371000000)
 	testWorkflowType = "test-wf-type"
 	testWorkflowID   = "test-wid"
-	testRunID        = "1601da05-4db9-4eeb-89e4-da99481bdfc9"
 	testCloseStatus  = int32(1)
 
 	testRequest = &p.InternalListWorkflowExecutionsRequest{
@@ -83,13 +82,6 @@ var (
 
 	testContextTimeout = 5 * time.Second
 
-	filterOpen     = "must_not:map[exists:map[field:CloseStatus]]"
-	filterClose    = "map[exists:map[field:CloseStatus]]"
-	filterByType   = fmt.Sprintf("map[match:map[WorkflowType:map[query:%s]]]", testWorkflowType)
-	filterByWID    = fmt.Sprintf("map[match:map[WorkflowID:map[query:%s]]]", testWorkflowID)
-	filterByRunID  = fmt.Sprintf("map[match:map[RunID:map[query:%s]]]", testRunID)
-	filterByStatus = fmt.Sprintf("map[match:map[CloseStatus:map[query:%v]]]", testCloseStatus)
-
 	esIndexMaxResultWindow = 3
 )
 

@@ -994,17 +994,6 @@ func (m *executionManagerImpl) fromInternalReplicationTaskInfo(internalInfo *Int
 	}
 }
 
-func (m *executionManagerImpl) toInternalReplicationTaskInfos(infos []*ReplicationTaskInfo) []*InternalReplicationTaskInfo {
-	if infos == nil {
-		return nil
-	}
-	internalInfos := make([]*InternalReplicationTaskInfo, len(infos))
-	for i := 0; i < len(infos); i++ {
-		internalInfos[i] = m.toInternalReplicationTaskInfo(infos[i])
-	}
-	return internalInfos
-}
-
 func (m *executionManagerImpl) toInternalReplicationTaskInfo(info *ReplicationTaskInfo) *InternalReplicationTaskInfo {
 	if info == nil {
 		return nil

@@ -79,13 +79,6 @@ const (
 		`and task_id > ? ` +
 		`and task_id <= ?`
 
-	templateCompleteTaskQuery = `DELETE FROM tasks ` +
-		`WHERE domain_id = ? ` +
-		`and task_list_name = ? ` +
-		`and task_list_type = ? ` +
-		`and type = ? ` +
-		`and task_id = ?`
-
 	templateCompleteTasksLessThanQuery = `DELETE FROM tasks ` +
 		`WHERE domain_id = ? ` +
 		`AND task_list_name = ? ` +

@@ -40,7 +40,6 @@ var (
 
 // ddb represents a logical connection to DynamoDB database
 type ddb struct {
-	logger log.Logger
 }
 
 var _ nosqlplugin.DB = (*ddb)(nil)

@@ -24,7 +24,6 @@ import (
 	"context"
 
 	"github.com/uber/cadence/common/persistence/nosql/nosqlplugin"
-	"github.com/uber/cadence/common/persistence/nosql/nosqlplugin/cassandra/gocql"
 )
 
 // Insert a new record to domain, return error if failed or already exists
@@ -36,14 +35,6 @@ func (db *ddb) InsertDomain(
 	panic("TODO")
 }
 
-func (db *ddb) updateMetadataBatch(
-	ctx context.Context,
-	batch gocql.Batch,
-	notificationVersion int64,
-) {
-	panic("TODO")
-}
-
 // Update domain
 func (db *ddb) UpdateDomain(
 	ctx context.Context,

@@ -24,7 +24,6 @@ import (
 	"context"
 
 	"github.com/uber/cadence/common/persistence/nosql/nosqlplugin"
-	"github.com/uber/cadence/common/persistence/nosql/nosqlplugin/cassandra/gocql"
 )
 
 // Insert a new record to domain, return error if failed or already exists
@@ -36,14 +35,6 @@ func (db *mdb) InsertDomain(
 	panic("TODO")
 }
 
-func (db *mdb) updateMetadataBatch(
-	ctx context.Context,
-	batch gocql.Batch,
-	notificationVersion int64,
-) {
-	panic("TODO")
-}
-
 // Update domain
 func (db *mdb) UpdateDomain(
 	ctx context.Context,