Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server and CLI use version from release and versionChecking constant and commit revision #4308

Merged
merged 13 commits into from
Jul 31, 2021
Merged

Server and CLI use version from release and versionChecking constant and commit revision #4308

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f192f68
CLI use version from versionChecking constant
longquanzheng Jul 9, 2021
2250078
update
longquanzheng Jul 9, 2021
410a0ae
update
longquanzheng Jul 9, 2021
de84864
fix
longquanzheng Jul 9, 2021
ddf4175
make file
longquanzheng Jul 9, 2021
a0a13f2
fix
longquanzheng Jul 9, 2021
9a7240a
fix
longquanzheng Jul 9, 2021
583f840
fix format
longquanzheng Jul 30, 2021
3b30dd9
add release version to docker arg
longquanzheng Jul 30, 2021
a6c3f75
fix all
longquanzheng Jul 31, 2021
382f433
also change server
longquanzheng Jul 31, 2021
3af0615
revert unnessary change
longquanzheng Jul 31, 2021
47c3d69
revert unnessary change
longquanzheng Jul 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert unnessary change
  • Loading branch information
@longquanzheng
longquanzheng committed Jul 31, 2021
commit 3af0615c97624eea2a5cba104ac70f22fb39ab4a
6 changes: 5 additions & 1 deletion common/authorization/oauthAuthorizer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,11 @@ func (a *oauthAuthority) validatePermission(claims *jwtClaims, attributes *Attri
case PermissionWrite:
groups = data[common.DomainDataKeyForWriteGroups]
default:
return fmt.Errorf("token doesn't have permission for admin API")
if claims.Admin {
return nil
} else {
return fmt.Errorf("token doesn't have permission for admin API")
}
}
// groups are separated by space
jwtGroups := strings.Split(groups, groupSeparator)
Expand Down