-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server and CLI use version from release and versionChecking constant and commit revision #4308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longquanzheng
changed the title
CLI use version from versionChecking constant
CLI use version from release and versionChecking constant and commit revision
Jul 9, 2021
This will improve #4305 |
github-actions
bot
force-pushed
the
qlong-cli-version
branch
from
July 23, 2021 18:04
a3c20bc
to
6fc1379
Compare
longquanzheng
force-pushed
the
qlong-cli-version
branch
from
July 31, 2021 00:02
6fc1379
to
a6c3f75
Compare
longquanzheng
changed the title
CLI use version from release and versionChecking constant and commit revision
All binaries use version from release and versionChecking constant and commit revision
Jul 31, 2021
longquanzheng
changed the title
All binaries use version from release and versionChecking constant and commit revision
Server and CLI use version from release and versionChecking constant and commit revision
Jul 31, 2021
yycptt
approved these changes
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
CLI and server use version from versionChecking constant
Why?
See Slack/StackOverflow and Github issues. There are lots of complaints recently.
One thing we need to improve is the versioning of CLI and server
The original intention of the current version is to track updates on the CLI development, with major.minor.patch semantics.
However, it turns out to be difficult to maintain this way.
And this information is usually not useful.
There is other more useful information is the version that CLI is sending request with.
https://github.com/uber/cadence/blob/c185ad8c149b47114df1bc547a0cfd82f2c60d12/tools/cli/factory.go#L127
And also usually the best way to make sure compatibility is the CLI is from the same release as server.
Using those versions will be more meaningful to understand the compatibility, and less/no maintenance required for development.
How did you test it?
Server:
CLI Docker image:
and then
Potential risks
No.
Release notes
Users may be confused about this version change from
0.19
to1.7.0
Should add clarification of this change in the release notes.
Documentation Changes
No