Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scanner] handle current execution to read from blobstore #3435

Merged
merged 10 commits into from
Aug 5, 2020
Merged

[Scanner] handle current execution to read from blobstore #3435

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c63a057
Pinned gocql version
yux0 Jul 30, 2020
2001947
Fix get dlq size NPE (#3422)
yux0 Jul 31, 2020
53da38c
[Scanner] Use CurrentExecution instead of base one (#3421)
mkolodezny Jul 31, 2020
7ba0d7f
Fix task attempt metrics in priority task processor (#3428)
yycptt Aug 4, 2020
232e820
Drop stuck close execution transfer task (#3240) (#3429)
yycptt Aug 4, 2020
d74d2f2
Fix sticky decision keeps failing on ConditionFailedError (#3423)
vancexu Aug 4, 2020
aad128d
[Scanner] Fixed missing scan type param in activities (#3434)
mkolodezny Aug 5, 2020
cc27612
[Scanner] handle current execution for blobstore
mkolodezny Aug 5, 2020
77d1af4
Merge branch 'master' into patch
mkolodezny Aug 5, 2020
c5cab82
reverted go.mod
mkolodezny Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix get dlq size NPE (#3422)
  • Loading branch information
@yux0 @mkolodezny
yux0 authored and mkolodezny committed Aug 4, 2020
commit 200194796d6575939f771498d3cc1930f06795a8
20 changes: 9 additions & 11 deletions service/history/replication/task_processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,22 +536,20 @@ func (p *taskProcessorImpl) emitDLQSizeMetricsLoop() {
select {
case <-timer.C:
resp, err := p.shard.GetExecutionManager().GetReplicationDLQSize(staticRequest)
if err != nil {
p.logger.Error("failed to get one task from replication DLQ", tag.Error(err))
p.metricsClient.Scope(metrics.ReplicationDLQStatsScope).IncCounter(metrics.ReplicationDLQProbeFailed)
}

p.metricsClient.Scope(
metrics.ReplicationDLQStatsScope,
metrics.InstanceTag(strconv.Itoa(p.shard.GetShardID())),
).UpdateGauge(metrics.ReplicationDLQSize, float64(resp.Size))

timer.Reset(backoff.JitDuration(
dlqMetricsEmitTimerInterval,
dlqMetricsEmitTimerCoefficient,
))
if err != nil {
p.logger.Error("failed to get replication DLQ size", tag.Error(err))
p.metricsClient.Scope(metrics.ReplicationDLQStatsScope).IncCounter(metrics.ReplicationDLQProbeFailed)
} else {
p.metricsClient.Scope(
metrics.ReplicationDLQStatsScope,
metrics.InstanceTag(strconv.Itoa(p.shard.GetShardID())),
).UpdateGauge(metrics.ReplicationDLQSize, float64(resp.Size))
}
case <-p.done:
timer.Stop()
return
}
}
Expand Down