[Scanner] handle current execution to read from blobstore #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rkflow#3423) When rangeID changed and sticky task ConditionFailedError happened, it is possible for the sticky tasklist to go into a bad state that none task can be added to it because of endless ConditionFailedError. This will cause latency increase for workflow, because all sticky decision task timeout (and workflow can only progress by using normal tasklist) Once it happened, the only possible way to recover is for user to restart workers (with those affected tasklists) We want to stablize the tasklist rangeID so that no need for worker to restart to recover using the sticky tasklist. This PR use a relatively conservative approach to stop infinite retrying sticky failures on ConditionFailedError. By reducing concurrent access to tasklist, it will be more likely to break the endless ConditionFailedError. Another approach would be clear stickness on worker side, but there would be bigger changes and risks.
…ow#3434) * [Scanner] Fixed missing scan type param in activities
yycptt
approved these changes
Aug 5, 2020
mkolodezny
added a commit
to mkolodezny/cadence
that referenced
this pull request
Aug 20, 2020
…rkflow#3435) * [Scanner] handle current execution to read from blobstore (cadence-workflow#3435)
yux0
pushed a commit
that referenced
this pull request
Sep 1, 2020
* [Scanner] handle current execution to read from blobstore (#3435)
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
…rkflow#3435) * [Scanner] handle current execution to read from blobstore (cadence-workflow#3435)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.