Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/help #105

Merged
merged 39 commits into from
Mar 20, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
2b47069
restructuring and removing unused code
just-at-uber Mar 16, 2020
6856b11
adding tab navigation component to help with reusability
just-at-uber Mar 16, 2020
61e71ce
adding icons
just-at-uber Mar 17, 2020
2429aa0
refactor to use component
just-at-uber Mar 17, 2020
b44e8da
adding alias for components
just-at-uber Mar 17, 2020
ed3a153
added more alias. trying to get mocha tests working again.
just-at-uber Mar 17, 2020
f0f1788
Merge branch 'master' into feature/help
just-at-uber Mar 18, 2020
8535ced
eslint
just-at-uber Mar 18, 2020
35d7100
fixing help styling
just-at-uber Mar 18, 2020
eb1b32e
added video embed
just-at-uber Mar 18, 2020
f480335
hiding faq section.
just-at-uber Mar 18, 2020
b4a9800
3.12.0-beta.0
just-at-uber Mar 18, 2020
7396247
adding slot to help to enable extention
just-at-uber Mar 18, 2020
23210c8
3.12.0-beta.1
just-at-uber Mar 18, 2020
d5a24f5
moving slot
just-at-uber Mar 19, 2020
e90ca65
3.12.0-beta.2
just-at-uber Mar 19, 2020
9f67546
adding more slots for extra customization
just-at-uber Mar 19, 2020
85f4f07
3.12.0-beta.3
just-at-uber Mar 19, 2020
90670d0
moving getting started slot. Making slack option able to be hidden
just-at-uber Mar 19, 2020
a988626
3.12.0-beta.4
just-at-uber Mar 19, 2020
b0cb288
adding option to hide stack overflow link
just-at-uber Mar 19, 2020
0c9a1a4
3.12.0-beta.5
just-at-uber Mar 19, 2020
7041c9a
adding cadence-web link
just-at-uber Mar 19, 2020
43e8860
3.12.0-beta.6
just-at-uber Mar 19, 2020
37d1b2a
removing hidden image for links on help screen
just-at-uber Mar 19, 2020
2a88ce9
3.12.0-beta.7
just-at-uber Mar 19, 2020
785b596
making headers linkable which will navigate to that place in the page…
just-at-uber Mar 19, 2020
63d1898
3.12.0-beta.8
just-at-uber Mar 19, 2020
521cb88
allow hiding docs link
just-at-uber Mar 19, 2020
6e36077
3.12.0-beta.9
just-at-uber Mar 19, 2020
1d90a22
renaming intro to domain-search test. adding new tests for help page
just-at-uber Mar 19, 2020
af12068
fixing intgration tests
just-at-uber Mar 19, 2020
b9ef990
adding CLI section. placeholder content for now.
just-at-uber Mar 19, 2020
c357b6b
fixing link and adding tests for CLI
just-at-uber Mar 19, 2020
fbf4d1f
adding common cli commands
just-at-uber Mar 20, 2020
e70cec6
3.12.0-beta.10
just-at-uber Mar 20, 2020
7df3bc8
adding see more cli commands link
just-at-uber Mar 20, 2020
b515257
3.12.0-beta.11
just-at-uber Mar 20, 2020
07a16d4
3.12.0
just-at-uber Mar 20, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
eslint
  • Loading branch information
just-at-uber committed Mar 18, 2020
commit 8535ced7bc9419126ef16e8a35cb9d6c93a618ef
12 changes: 6 additions & 6 deletions client/components/navigation-bar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ export default {
</script>

<style lang="stylus">
.navigation-bar {
flex-wrap: wrap;
background-color: #000;
padding: 0 12px;
}
</style>
.navigation-bar {
flex-wrap: wrap;
background-color: #000;
padding: 0 12px;
}
</style>
44 changes: 17 additions & 27 deletions client/components/navigation-link.vue
Original file line number Diff line number Diff line change
@@ -1,42 +1,32 @@
<template>
<router-link
class="navigation-link"
:class="icon"
:exact="exact"
:to="to"
>
<router-link class="navigation-link" :class="icon" :exact="exact" :to="to">
{{ label }}
</router-link>
</template>

<script>
export default {
name: 'navigation-link',
props: [
'exact',
'icon',
'label',
'to'
],
props: ['exact', 'icon', 'label', 'to'],
};
</script>

<style lang="stylus">
a.navigation-link {
display: inline-block;
padding: 11px 18px;
transition: all 400ms ease;
font-weight: 500;
text-transform: uppercase;
border-bottom: 4px solid transparent;
a.navigation-link {
display: inline-block;
padding: 11px 18px;
transition: all 400ms ease;
font-weight: 500;
text-transform: uppercase;
border-bottom: 4px solid transparent;

&:before {
font-family: 'uber-icons';
margin-right: 5px;
}
&:before {
font-family: 'uber-icons';
margin-right: 5px;
}

&.router-link-active {
border-bottom-color: #11939a;
}
&.router-link-active {
border-bottom-color: #11939a;
}
</style>
}
</style>
2 changes: 1 addition & 1 deletion client/helpers/get-error-message.spec.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { NOTIFICATION_TYPE_ERROR_MESSAGE_DEFAULT } from '~constants';
import getErrorMessage from './get-error-message';
import { NOTIFICATION_TYPE_ERROR_MESSAGE_DEFAULT } from '~constants';

describe('getErrorMessage', () => {
describe('When passing error.json.message', () => {
Expand Down
2 changes: 1 addition & 1 deletion client/helpers/get-key-value-pairs.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import moment from 'moment';
import { jsonKeys, preKeys } from '~constants';
import getJsonStringObject from './get-json-string-object';
import { jsonKeys, preKeys } from '~constants';

const getKeyValuePairs = event => {
const kvps = [];
Expand Down
2 changes: 1 addition & 1 deletion client/helpers/get-string-elipsis.spec.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { MAXIMUM_JSON_CHARACTER_LIMIT, MAXIMUM_JSON_MESSAGE } from '~constants';
import getStringElipsis from './get-string-elipsis';
import { MAXIMUM_JSON_CHARACTER_LIMIT, MAXIMUM_JSON_MESSAGE } from '~constants';

describe('getStringElipsis', () => {
describe('when passed a string that has a length less than MAXIMUM_JSON_CHARACTER_LIMIT', () => {
Expand Down
2 changes: 1 addition & 1 deletion client/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const routeOpts = {
path: '/help',
component: Help,
},
]
],
},
{
name: 'workflows',
Expand Down
2 changes: 1 addition & 1 deletion client/routes/execution/helpers/get-summary.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { getJsonStringObject, getKeyValuePairs } from '~helpers';
import getSummaryWorkflowStatus from './get-summary-workflow-status';
import parentWorkflowLink from './parent-workflow-link';
import { getJsonStringObject, getKeyValuePairs } from '~helpers';

const getSummary = ({ events, isWorkflowRunning, workflow }) => {
const formattedWorkflow = workflow.pendingActivities
Expand Down
1 change: 0 additions & 1 deletion client/routes/help.vue
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
</template>

<script>

export default {
data() {
return {};
Expand Down
12 changes: 3 additions & 9 deletions client/routes/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,7 @@
label="Search"
:to="{ name: 'domain-search' }"
/>
<navigation-link
label="Help"
icon="icon_help"
:to="{ name: 'help' }"
/>
<navigation-link label="Help" icon="icon_help" :to="{ name: 'help' }" />
</navigation-bar>
<router-view />
</section>
Expand All @@ -24,10 +20,8 @@ export default {
components: {
'navigation-bar': NavigationBar,
'navigation-link': NavigationLink,
}
},
};
</script>

<style lang="stylus">

</style>
<style lang="stylus"></style>