Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include all languages by default in wit-bindgen test #1246

Merged

Conversation

alexcrichton
Copy link
Member

Instead switch the -l/--language argument to a required argument. I'm backtracking on "include everything" being a reasonable default since I don't think most users actually want to test everything. Short of that this requires explicit opt-in for what to test.

Instead switch the `-l`/`--language` argument to a required argument.
I'm backtracking on "include everything" being a reasonable default
since I don't think most users actually want to test everything. Short
of that this requires explicit opt-in for what to test.
Copy link
Contributor

@pchickey pchickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, all languages is not the desirable default.

@alexcrichton alexcrichton added this pull request to the merge queue Mar 31, 2025
Merged via the queue into bytecodealliance:main with commit c30dc9a Mar 31, 2025
18 checks passed
@alexcrichton alexcrichton deleted the opt-in-what-to-test branch March 31, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants