Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(moonbit): use internal abi #1243

Merged
merged 5 commits into from
Mar 26, 2025

Conversation

peter-jerry-ye
Copy link
Contributor

This PR made a lot of hand written inline wasm to call the builtin functions, so that:

  1. less bugs
  2. prepare for migrating the memory layout.

This PR also adapts the new test framework for MoonBit.

@peter-jerry-ye
Copy link
Contributor Author

@alexcrichton The new test framework was great. It helped me find a number of bugs.

I wonder though if we can exclude MoonBit from the default language testing set for now? (same reason as why it's not in the CI, it's not that stable yet) I tried not to add MoonBit to ALL but then the codegen test won't run for MoonBit even if I set --languages moonbit.

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

I'll work on integrating a better set of defaults into wit-bindgen test to get tests working for this with explicit opt-in, but for now seems reasonable to have this as-is

@alexcrichton alexcrichton added this pull request to the merge queue Mar 26, 2025
Merged via the queue into bytecodealliance:main with commit e8a3745 Mar 26, 2025
18 checks passed
@alexcrichton
Copy link
Member

Ok in #1246 I'm going to just require that --language is always passed to request something explicitly and avoid the "include everything" behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants