Bring back legacy exception handling opcodes #1661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eption-handling-opcodes
|
@alexcrichton Okay, I changed 'cargo feature' to WasmFeatures and I added simple wat test file. I also changed some names and description, I think it's ready for review. |
alexcrichton
approved these changes
Jul 12, 2024
alexcrichton
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this MR I bring back legacy exception handling opcodes, in reference to this report: #1653.
@alexcrichton Two things:
I have prepared the simplest wasm file possible which uses all the deprecated opcodes (see
check_legacy_exception_handling_opcodestest function),could you please help me run the validator with this data?
Since this is behind the
legacy-exception-handlingfeature, tests should be run with thecargo test --all-featuresflag, or I can add this feature to default list.Given this, how should I do it to make sense?