Fold resolve_world_from_name helper into select_world#1611
Merged
alexcrichton merged 3 commits intobytecodealliance:mainfrom Jun 11, 2024
Merged
Fold resolve_world_from_name helper into select_world#1611alexcrichton merged 3 commits intobytecodealliance:mainfrom
resolve_world_from_name helper into select_world#1611alexcrichton merged 3 commits intobytecodealliance:mainfrom
Conversation
This is a follow-up to bytecodealliance#1577 to refactor a bit to have bindings generators continue to use `Resolve::select_world` for figuring out what to generate bindings for.
pchickey
approved these changes
Jun 11, 2024
Contributor
pchickey
left a comment
pchickey
left a comment
There was a problem hiding this comment.
Thanks, this solves the problems I was having with the upgrade!
crates/wit-parser/src/resolve.rs
Outdated
| } | ||
|
|
||
| fn parse_into(resolve: &mut Resolve, wit: &str) -> PackageId { | ||
| fn parse_into(resolve: &mut Resolve, wit: &str) -> Vec<PackageId> { |
Contributor
There was a problem hiding this comment.
How do you feel about making this a pub method (take &mut Self)? We do the same UnresolvedPackageGroup::parse Resolve::append pattern in many places in test code.
* Rename `Resolve::append` to `Resolve::push_group` * Add `Resolve::push_str` * Change `&Path` arguments to `impl AsRef<Path>`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1577 to refactor a bit to have bindings generators continue to use
Resolve::select_worldfor figuring out what to generate bindings for.