Implement atomic and memset/memmove/memcpy intrinsic for riscv #841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no1wudi
force-pushed
the
main
branch
2 times, most recently
from
5d89235 to
a6f3c68
Compare
wenyongh
reviewed
Nov 22, 2021
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
Signed-off-by: Huang Qi <no1wudi@qq.com>
no1wudi
changed the title
wenyongh
reviewed
Nov 30, 2021
| void | ||
| aot_add_expand_memory_op_pass(LLVMPassManagerRef pass) | ||
| { | ||
| unwrap(pass)->add(new ExpandMemoryOpPass()); |
There was a problem hiding this comment.
Should check return value of new ExpandMemoryOpPass(), and change return value of aot_add_expand_memory_op_pass from void to bool?
There was a problem hiding this comment.
If new operation failed, wamrc will crash and report an exception to notify user.
I think it's enough for debug purpose.
| return false; | ||
| } | ||
|
|
||
| aot_add_expand_memory_op_pass(common_pass_mgr); |
There was a problem hiding this comment.
Should check return value
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…odealliance#841) - Lower aotmic instruction to non-atomic form on some platforms - Lower memset/memmove/memcpy for XIP - Disable rtti in cmake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.