rebase with upstream #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: GitHub commits: facebook/fb303@88a409a facebook/fbthrift@8784ef4 facebookarchive/fbzmq@ab44696 facebook/folly@68b0345 facebook/proxygen@d83e9ee facebook/wangle@554c187 facebook/watchman@e4beeef facebookincubator/fizz@3ee9d30 facebookincubator/katran@b5e5ed9 facebook/mvfst@5bd5150 facebookincubator/velox@8be2a9d Reviewed By: yns88 fbshipit-source-id: 537d6beaeb6c262f2ffad90a756aa1f3be347a76
Summary: GitHub commits: facebook/fb303@fd98a1f facebook/fbthrift@e4c9cb7 facebookarchive/fbzmq@fa80654 facebook/proxygen@9c25f54 facebook/wangle@7e2983c facebook/watchman@cd3dc2b facebookexperimental/rust-shed@b4cf40a facebookincubator/fizz@d0c117f facebookincubator/katran@0963f46 facebook/mvfst@19e60c9 facebookincubator/velox@83416e1 Reviewed By: yns88 fbshipit-source-id: 4b514439a70ff17569f9d4606016cc05af8cc876
Summary: GitHub commits: facebook/fb303@3104032 facebook/fbthrift@127ffd9 facebookarchive/fbzmq@4de3bfb facebook/folly@84ff4e5 facebook/proxygen@322cae9 facebook/wangle@40f0876 facebook/watchman@ff09e82 facebookexperimental/rust-shed@592674e facebookincubator/katran@bf2c33f facebook/mvfst@cecc65e Reviewed By: yns88 fbshipit-source-id: f72e3677a0774288d37fb4f9ab641e3c8ea9669d
Summary: GitHub commits: facebook/fb303@3ee5175 facebook/fbthrift@6860571 facebookarchive/fbzmq@979cbf9 facebook/proxygen@fe1209d facebook/wangle@5f53789 facebook/watchman@407ff25 facebookexperimental/rust-shed@8b23eda facebookincubator/fizz@94acdc4 facebookincubator/katran@97fb177 facebook/mvfst@5312449 facebookincubator/velox@0a050a9 Reviewed By: yns88 fbshipit-source-id: 18ce665b03e12007edec343d29eb977fbde86400
Summary: GitHub commits: facebook/fb303@2866e66 facebook/fbthrift@887f6aa facebookarchive/fbzmq@5a987a5 facebook/proxygen@c102d6e facebook/wangle@a3e382e facebook/watchman@7da17da facebookexperimental/rust-shed@8f2cf67 facebookincubator/katran@28765ea facebook/mvfst@4bc0937 Reviewed By: yns88 fbshipit-source-id: 0ca6e31835efe9ffa7c29adf0652760518962122
Summary: GitHub commits: facebook/fb303@266f2aa facebook/fbthrift@ccfa1fb facebookarchive/fbzmq@f73884d facebook/proxygen@79bc8b7 facebook/watchman@ea71456 facebookexperimental/rust-shed@c31f13d Reviewed By: yns88 fbshipit-source-id: a555de51c1eb093c20841737ad73be796d1903a7
Summary: GitHub commits: facebook/fbthrift@0b99543 Reviewed By: yns88 fbshipit-source-id: 21801a621629d40eafe6ab866ed5952cd6b1de5b
Summary: GitHub commits: facebook/folly@53e82da Reviewed By: yns88 fbshipit-source-id: 3b65709eeb8dfeb606646e8fc59016c25cc3656e
Summary: GitHub commits: facebook/fb303@5f5d25a facebook/fbthrift@28dee94 facebookarchive/fbzmq@60db71a facebook/proxygen@10b677d facebook/wangle@cd887eb facebook/watchman@db96b37 facebookincubator/fizz@b44a911 facebookincubator/katran@1e7125d facebook/mvfst@9607290 facebookincubator/velox@843b1cb Reviewed By: yns88 fbshipit-source-id: c2f86eb7606b4510c0be5046955d4272da26b907
Summary: GitHub commits: facebook/fb303@9b6c369 facebook/fbthrift@183e77d facebookarchive/fbzmq@0b8a727 facebook/proxygen@7b50f9c facebook/wangle@3c16829 facebook/watchman@f0db862 facebookexperimental/rust-shed@5a3eb92 facebookincubator/katran@8b0676c facebook/mvfst@87d3228 Reviewed By: yns88 fbshipit-source-id: d7a3b9079246ca495fb17b2a82943396c8769263
Summary: GitHub commits: facebook/fb303@2d1b91f facebook/fbthrift@381b872 facebookarchive/fbzmq@3f5abfa facebook/proxygen@5408eaa facebook/watchman@b1a400a facebookexperimental/rust-shed@cc1a396 Reviewed By: yns88 fbshipit-source-id: c9b4d457c4968a72d062f36790ea163decc91a99
Summary: GitHub commits: facebook/fbthrift@5c8e1ee Reviewed By: yns88 fbshipit-source-id: 6758c0058c8cfeefb446524f0acdd43e80d7ee28
Summary: GitHub commits: facebook/fbthrift@a0a3b22 Reviewed By: yns88 fbshipit-source-id: caafa622ff7bddce0f63a777199f9e6c9ca0d8c4
Summary: GitHub commits: facebook/fb303@74ab2e1 facebook/fbthrift@5928918 facebookarchive/fbzmq@848389f facebook/folly@5da36fa facebook/proxygen@85131d1 facebook/rocksdb@a3de7ae facebook/wangle@1ce0041 facebook/watchman@07fde9b facebookexperimental/rust-shed@364c1d9 facebookincubator/fizz@7aa7280 facebookincubator/katran@e09867c facebook/mvfst@5f058c7 facebookincubator/velox@7c3b975 Reviewed By: jurajh-fb fbshipit-source-id: 5ec1775b46bd390bf69346d3c4d11306296a0b3a
Summary: GitHub commits: facebook/fb303@48db955 facebook/fbthrift@4cb15dc facebookarchive/fbzmq@fff3453 facebook/folly@7725223 facebook/proxygen@46dc910 facebook/wangle@c7ff829 facebook/watchman@e225863 facebookexperimental/rust-shed@d0e9812 facebookincubator/fizz@a95dd71 facebookincubator/katran@c6e9093 facebook/mvfst@4f63055 facebookincubator/velox@3573f73 Reviewed By: jurajh-fb fbshipit-source-id: d0d27fbd5098ebcb5cfbfc465027faac496c37e7
Summary: GitHub commits: facebook/fb303@ab21a96 facebook/fbthrift@819c5b3 facebookarchive/fbzmq@cbf5266 facebook/proxygen@13dd2fe facebook/wangle@cdfa5b9 facebook/watchman@1fee8ec facebookexperimental/rust-shed@6ad8873 facebookincubator/fizz@eb36a57 facebookincubator/katran@146a527 facebook/mvfst@09d6e45 facebookincubator/velox@fa40656 Reviewed By: jurajh-fb fbshipit-source-id: e2731889609e25267124d506f780715a176c571c
Summary: GitHub commits: facebook/fb303@2075b5c facebook/fbthrift@7b068cb facebookarchive/fbzmq@0aed20b facebook/proxygen@556a06a facebook/wangle@3e95421 facebook/watchman@b5dc3cb facebookexperimental/rust-shed@3bae732 facebookincubator/katran@c3a7a1b facebook/mvfst@5849193 Reviewed By: jurajh-fb fbshipit-source-id: 6e2bd10c5b72179820a5ad98728f110853a5f808
Summary: GitHub commits: facebook/fb303@86d749b facebook/fbthrift@814aca1 facebookarchive/fbzmq@bca6b47 facebook/folly@8d41a26 facebook/proxygen@bea3e44 facebook/rocksdb@c7ce03d facebook/wangle@5d7029e facebook/watchman@3d934d7 facebookexperimental/rust-shed@451cdcb facebookincubator/fizz@b4f26ff facebookincubator/katran@7a50cba facebook/mvfst@3c5c81d facebookincubator/velox@559108e pytorch/FBGEMM@2711eca Reviewed By: jurajh-fb fbshipit-source-id: 82916842cbc06ae686f02041a02b409d5a4a6919
Summary: On some systems (e.g. macOS) O_DIRECT is not defined. Define it as zero. Reviewed By: therealgymmy Differential Revision: D33741808 fbshipit-source-id: d8a98128641448e3f4d7383279d82042b284b982
Summary: In C++17, random_shuffle() has been deprecated. Still available in GCC, but removed in CLANG. Replace with a non-deprecated equivalent. See: https://en.cppreference.com/w/cpp/algorithm/random_shuffle Reviewed By: therealgymmy Differential Revision: D33742049 fbshipit-source-id: 9feac85ea31e9b71ee4934ff38ac795b75e7ab32
Summary: This is a long-term solution instead of the 'quick fix' of D33661759 . fmt version >=8.1 changed internal structures and does not automatically format the 'DestructorContext' enum. Add a helper class to format the enum to strings, based on the example in https://fmt.dev/latest/api.html#udt . NOTE: This changes the debug output of the ItemRecords::validate() function (the last two parameters in the two XLOGF calls). Reviewed By: therealgymmy Differential Revision: D33662085 fbshipit-source-id: 608b498c762ca95cc71cb1597831a5c2a5f2c575
Summary: GitHub commits: facebook/fb303@ced9bf7 facebook/fbthrift@b382cf7 facebookarchive/fbzmq@b3daefc facebook/litho@82efa86 facebook/proxygen@8545290 facebook/squangle@9045f89 facebook/wangle@00110d9 facebook/watchman@20f1524 facebookexperimental/rust-shed@4bae795 facebookincubator/fizz@954bb5e facebookincubator/katran@9df9c45 facebook/mvfst@8611322 facebookincubator/velox@f573a84 facebookresearch/beanmachine@92dfc70 Reviewed By: jurajh-fb fbshipit-source-id: 5998ee15d8166feaad35ebba8a59ee72ff89f963
Summary: GitHub commits: facebook/fb303@7bc2b40 facebook/fbthrift@5a1e4d5 facebookarchive/fbzmq@a518753 facebook/proxygen@8fb4c65 facebook/wangle@880b361 facebook/watchman@ab6a566 facebookexperimental/rust-shed@b1104e3 facebookincubator/katran@62fbfe7 facebook/mvfst@942d00d pytorch/FBGEMM@bf48eea Reviewed By: jurajh-fb fbshipit-source-id: 41b941f762e59af4bd43b238bc4da270c03944ac
Summary: GitHub commits: facebook/fb303@208b849 facebook/fbthrift@ee1b58c facebookarchive/fbzmq@7006dea facebook/proxygen@ae2edea facebook/watchman@84f691f facebookexperimental/rust-shed@4bcf360 Reviewed By: jurajh-fb fbshipit-source-id: cfdbec95bd00167d9c62d8225b69df422e7af88d
Summary: GitHub commits: facebook/fb303@8570249 facebook/fbthrift@b5d1860 facebookarchive/fbzmq@3923f20 facebook/folly@568f1c6 facebook/proxygen@4c30587 facebook/wangle@d9fc09c facebook/watchman@1d6cd02 facebookexperimental/rust-shed@47cbaa7 facebookincubator/fizz@4b2db70 facebookincubator/katran@a072e11 facebook/mvfst@4f8e44f facebookincubator/velox@6a87f83 Reviewed By: jurajh-fb fbshipit-source-id: cfba16d91d1011099c6dcb679bea766715599727
Summary: GitHub commits: facebook/fb303@2ad1d8a facebook/fbthrift@b972d8c facebookarchive/fbzmq@c2d90bf facebook/proxygen@1f4a5f7 facebook/rocksdb@f6d7ec1 facebook/wangle@d95aaf9 facebook/watchman@90dee7f facebookexperimental/rust-shed@23b912d facebookincubator/fizz@a85b1ea facebookincubator/katran@a00a471 facebook/mvfst@9b7d89b facebookincubator/velox@adc98c6 Reviewed By: jurajh-fb fbshipit-source-id: 620e62ec2c66a6ac4e08ff52a7326b6b33b7cf75
Summary: GitHub commits: facebook/fb303@331ad61 facebook/fbthrift@7808a25 facebookarchive/fbzmq@997dff7 facebook/proxygen@578a49b facebook/wangle@db88679 facebook/watchman@ca5ea53 facebookexperimental/rust-shed@b361e77 facebookincubator/katran@fbd2d7c facebook/mvfst@c2b0c78 Reviewed By: jurajh-fb fbshipit-source-id: a805ab5a6ef9544bf46859a0ba54e81523b04ce0
Summary: GitHub commits: facebook/fb303@955dad7 facebook/fbthrift@03bce48 facebookarchive/fbzmq@848f9c8 facebook/proxygen@945ca01 facebook/watchman@796de33 facebookexperimental/rust-shed@eb367c6 facebookincubator/velox@7c740c7 Reviewed By: jurajh-fb fbshipit-source-id: 78ddf5994d314aa6cb6aeeeca2b415f8be3dd587
Summary: GitHub commits: facebook/fb303@4033828 facebook/fbthrift@b0cf81e facebookarchive/fbzmq@10a06a4 facebook/folly@ea1dd51 facebook/proxygen@846396a facebook/wangle@762854c facebook/watchman@b9a6975 facebookexperimental/rust-shed@197b960 facebookincubator/fizz@dffc75d facebookincubator/katran@b87d5de facebook/mvfst@cf03704 facebookincubator/velox@d6f4c47 Reviewed By: jurajh-fb fbshipit-source-id: 78c54eb64c3e9353772a61fb6bc1227c683bf1db
Summary: GitHub commits: facebook/fb303@7b3d7a9 facebook/fbthrift@c8a360f facebookarchive/fbzmq@56843c8 facebook/proxygen@36f5933 facebook/wangle@b7c0496 facebook/watchman@222ecf9 facebookexperimental/rust-shed@00578fb facebookincubator/fizz@ab34d7d facebookincubator/katran@fc9de0b facebook/mvfst@fd19c90 facebookincubator/velox@3175c2d Reviewed By: jurajh-fb fbshipit-source-id: ba2e86c25afc5cad86ebd527fe3e2142c9988459
Disabled test suite allocator-test-AllocatorTypeTest to skip sporadically failing tests.
Compensation results in ratios being different than originially specified.
Return a sum of sizes of each tier instead of just 1st tier's size.
Compilation of some of the tests was failing with: "undefined reference to `facebook::cachelib::test_util::getRandomAsciiStr[abi:cxx11](unsigned int)'" Fix this by linking those tests with common/TestUtils.cpp Also, for some reason specyfing sources as in add_library(common_test_support INTERFACE [sources...]) did not work. Using target_sources works fine.
Centos8 is EOL
Update docker file used in CI
The issue happened when ReadHandleImpl ctor needs to destroy waitContext_ because addWaitContextForMovingItem() returns false. So before destroying waitContext_ we are calling discard method to notify ~ItemWaitContext() that Item is ready.
Fix issue with "Destorying an unresolved handle"
byrnedj
added a commit
that referenced
this pull request
Aug 17, 2022
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
byrnedj
pushed a commit
that referenced
this pull request
Sep 1, 2022
Summary: AdRanker ASAN canary flagged a possible UBSan violation. ## Error Failed Run: https://fburl.com/servicelab/apytosry ``` #0 0x562e3adb59bc in facebook::cachelib::objcache2::ObjectCacheSizeController<facebook::cachelib::CacheAllocator<facebook::cachelib::LruCacheTrait> >::work() buck-out/v2/gen/fbcode/47d914adeee3d982/cachelib/experimental/objcache2/__object-cache__/headers/cachelib/experimental/objcache2/ObjectCacheSizeController-inl.h #1 0x562de7610f78 in facebook::cachelib::PeriodicWorker::loop() fbcode/cachelib/common/PeriodicWorker.cpp:55 #2 0x7f7632c524e4 in execute_native_thread_routine /home/engshare/third-party2/libgcc/11.x/src/gcc-11.x/x86_64-facebook-linux/libstdc++-v3/src/c++11/../../../.././libstdc++-v3/src/c++11/thread.cc:82:18 #3 0x7f7632f6ec0e in start_thread /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/nptl/pthread_create.c:434:8 #4 0x7f76330011db in clone3 /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 UndefinedBehaviorSanitizer: integer-divide-by-zero buck-out/v2/gen/fbcode/47d914adeee3d982/cachelib/experimental/objcache2/__object-cache__/headers/cachelib/experimental/objcache2/ObjectCacheSizeController-inl.h:33:40 in ``` Reviewed By: jiayuebao Differential Revision: D39024188 fbshipit-source-id: 64ad644c360565e638fa3ca74616a315038382ab
byrnedj
added a commit
that referenced
this pull request
Sep 19, 2022
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
byrnedj
pushed a commit
that referenced
this pull request
Nov 12, 2022
Summary: The current exception string for MapIndexMaxedOut is not very useful because ```oldHashTable.viewWriteHandle()->getKey()``` can have null terminators in it and cause the c_str() to be terminated incorrectly. Regardless, the actual write handle key is not very useful to us. Log the aid explicitly. Example log: ``` Sep 14 07:12:57 tsp_lla/tao/prod-opt-follower/1879 dpdaemon[442]: E0914 07:12:57.836133 1922 Refill.cpp:215] Index has maxed out for key: #1<A4><D1 (https://github.com/facebook/CacheLib/commit/3ec18f5591f75fa5e247cadad19a86126075bdda)>0F<F6>\ ``` Reviewed By: vrishal Differential Revision: D39518530 fbshipit-source-id: 58b9f31f6c0d174d5ec0bc7705788408bc0d11f4
byrnedj
added a commit
that referenced
this pull request
Nov 12, 2022
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
byrnedj
added a commit
that referenced
this pull request
Dec 15, 2022
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests. remove extra whitespace Background data movement (pmem#20) Background data movement using periodic workers. Attempts to evict/promote items per given thresholds for each class. These reduce p99 latency since there is a higher chance that an allocation slot is free in the tier we are allocating in. remove extra whitespace removed the slab approx free percent check since it the value is close to 9.5 but not guaranteed to be >= 9.5
byrnedj
added a commit
that referenced
this pull request
Feb 2, 2023
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
byrnedj
added a commit
that referenced
this pull request
Feb 10, 2023
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
byrnedj
added a commit
that referenced
this pull request
Feb 15, 2023
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
byrnedj
added a commit
that referenced
this pull request
Feb 16, 2023
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
byrnedj
added a commit
that referenced
this pull request
Feb 24, 2023
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
byrnedj
added a commit
that referenced
this pull request
Feb 27, 2023
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
byrnedj
added a commit
that referenced
this pull request
Feb 27, 2023
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
byrnedj
added a commit
that referenced
this pull request
Feb 27, 2023
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
byrnedj
added a commit
that referenced
this pull request
Feb 28, 2023
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
byrnedj
added a commit
that referenced
this pull request
Mar 3, 2023
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
byrnedj
added a commit
that referenced
this pull request
Mar 3, 2023
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
byrnedj
added a commit
that referenced
this pull request
Jul 24, 2023
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
byrnedj
added a commit
that referenced
this pull request
Mar 12, 2024
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.